Opened 3 years ago

Closed 3 years ago

#32360 closed Cleanup/optimization (fixed)

Add system check that FILE_UPLOAD_TEMP_DIR exists when set

Reported by: Tim McCurrach Owned by: Tim McCurrach
Component: Core (Other) Version: 4.0
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Following discussion in this ticket https://code.djangoproject.com/ticket/32329

Add a check that if settings.FILE_UPLOAD_TEMP_DIR is set, then the directory actually exists. This is because if it doesn't exist it can lead to an OSError when python attempts to create a NamedTemporaryFile.

My only question is how this check should be categorised. It doesn't fit nicely into any of the existing tags. Would this merit a new tag? files?

Change History (5)

comment:1 by Mariusz Felisiak, 3 years ago

Component: Uncategorized → Core (Other)
Triage Stage: Unreviewed → Accepted
Version: 3.1 → 4.0

My only question is how this check should be categorised. It doesn't fit nicely into any of the existing tags. Would this merit a new tag? files?

files sounds good.

comment:2 by Tim McCurrach, 3 years ago

Has patch: set

comment:3 by Mariusz Felisiak, 3 years ago

Patch needs improvement: set

comment:4 by Mariusz Felisiak, 3 years ago

Patch needs improvement: unset
Triage Stage: Accepted → Ready for checkin

comment:5 by Mariusz Felisiak <felisiak.mariusz@…>, 3 years ago

Resolution: → fixed
Status: assigned → closed

In b1821fb:

Fixed #32360 -- Added system check for FILE_UPLOAD_TEMP_DIR setting.

Note: See TracTickets for help on using tickets.
Back to Top