#3232 closed enhancement (fixed)
[patch] apply_changes for all forms
Reported by: | Chris Beaven | Owned by: | Adrian Holovaty |
---|---|---|---|
Component: | Forms | Version: | |
Severity: | normal | Keywords: | |
Cc: | Triage Stage: | Unreviewed | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
It seems like the recently added apply_changes
method (to form_for_instance
) could be useful in other cases too if it was a bit more "open-minded".
Attachments (1)
Change History (4)
by , 18 years ago
Attachment: | apply_changes.patch added |
---|
comment:1 by , 18 years ago
comment:2 by , 18 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:3 by , 18 years ago
For the record, I took a different approach than the patch suggested. I wasn't comfortable with the default_instance
bit of magic on the Form
class, and I didn't like putting database-aware code in django/newforms/forms.py.
Note:
See TracTickets
for help on using tickets.
No tests added, just updated the wording of the existing tests. It will need some new ones, but I just wanted to show Adrian my idea to see if it has merit for now.
See previous discussion: http://groups-beta.google.com/group/django-developers/browse_thread/thread/9e2ecc980f6efda/deaa492428135f20