Log exceptions handled in Signal.send_robust()
As pointed out by Haki Benita on Twitter, by default Signal.send_robust() doesn't have any log messages for exceptions raised in receivers. Since Django logs exceptions in other similar situations, such as missing template variables, I think it would be worth adding a logger.exception() call in the except clause of send_robust() . Users would then see such exceptions in their error handling tools, e.g. Sentry, and be able to figure out what action to take from there. Ultimately any *expected* exception should be caught with a try in the receiver function.
Change History (6)
| Triage Stage: |
Unreviewed →
Accepted
|
| Owner: |
changed from nobody to Ayush Bansal
|
| Status: |
new →
assigned
|
| Patch needs improvement: |
set
|
| Patch needs improvement: |
unset
|
| Triage Stage: |
Accepted →
Ready for checkin
|
| Resolution: |
→ fixed
|
| Status: |
assigned →
closed
|
I would like to work on this issue.
PS. i am new to this django. so any advice would be appreciated