Opened 10 years ago

Closed 9 years ago

#3222 closed enhancement (duplicate)

Add validators for all admin options

Reported by: Robert Myers <myer0052@…> Owned by: nobody
Component: contrib.admin Version: newforms-admin
Severity: normal Keywords:
Cc: myer0052@…, brosner@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The file django.core.management.py has a few validations for admin options. But not all options are being tested. Ticket #3217 provides tests to verify whether each validator is working properly.

Here is a list of the missing validators:

  • search_fields
  • js
  • save_as
  • save_on_top
  • list_select_related
  • list_per_page
  • fields
  • ordering
  • manager

Attachments (1)

3222-newforms-admin.patch (33.8 KB) - added by Robert Myers <myer0052@…> 10 years ago.
This patch is for the newforms-admin branch

Download all attachments as: .zip

Change History (8)

comment:1 Changed 10 years ago by Robert Myers <myer0052@…>

Type: defectenhancement

comment:2 Changed 10 years ago by Robert Myers <myer0052@…>

Cc: myer0052@… added

Changed 10 years ago by Robert Myers <myer0052@…>

Attachment: 3222-newforms-admin.patch added

This patch is for the newforms-admin branch

comment:3 Changed 10 years ago by Robert Myers <myer0052@…>

Has patch: set
Triage Stage: UnreviewedDesign decision needed

I have attached a patch with complete tests for the newforms-admin branch. A design decision is needed because there are many changes. Also this patch fixes a minor error with the invalid_models test since the prepopulate_from option was moved.

comment:4 Changed 10 years ago by brosner <brosner@…>

Cc: brosner@… added

comment:5 Changed 9 years ago by James Bennett

Owner: changed from nobody to jkocherhans
Version: newforms-admin

Reassigning to jkocherhans since he's doing a lot of newforms-admin stuff.

comment:6 Changed 9 years ago by jkocherhans

Component: Core frameworkAdmin interface
Owner: changed from jkocherhans to nobody
Triage Stage: Design decision neededAccepted

I'm not actively working on this.

comment:7 Changed 9 years ago by jkocherhans

Resolution: duplicate
Status: newclosed

#5374 covers the same issue, but is more up to date.

Note: See TracTickets for help on using tickets.
Back to Top