Opened 18 years ago
Closed 17 years ago
#3222 closed enhancement (duplicate)
Add validators for all admin options
| Reported by: | Owned by: | nobody | |
|---|---|---|---|
| Component: | contrib.admin | Version: | newforms-admin |
| Severity: | normal | Keywords: | |
| Cc: | myer0052@…, brosner@… | Triage Stage: | Accepted |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
The file django.core.management.py has a few validations for admin options. But not all options are being tested. Ticket #3217 provides tests to verify whether each validator is working properly.
Here is a list of the missing validators:
- search_fields
- js
- save_as
- save_on_top
- list_select_related
- list_per_page
- fields
- ordering
- manager
Attachments (1)
Change History (8)
comment:1 by , 18 years ago
| Type: | defect → enhancement |
|---|
comment:2 by , 18 years ago
| Cc: | added |
|---|
by , 18 years ago
| Attachment: | 3222-newforms-admin.patch added |
|---|
comment:3 by , 18 years ago
| Has patch: | set |
|---|---|
| Triage Stage: | Unreviewed → Design decision needed |
I have attached a patch with complete tests for the newforms-admin branch. A design decision is needed because there are many changes. Also this patch fixes a minor error with the invalid_models test since the prepopulate_from option was moved.
comment:4 by , 18 years ago
| Cc: | added |
|---|
comment:5 by , 17 years ago
| Owner: | changed from to |
|---|---|
| Version: | → newforms-admin |
Reassigning to jkocherhans since he's doing a lot of newforms-admin stuff.
comment:6 by , 17 years ago
| Component: | Core framework → Admin interface |
|---|---|
| Owner: | changed from to |
| Triage Stage: | Design decision needed → Accepted |
I'm not actively working on this.
comment:7 by , 17 years ago
| Resolution: | → duplicate |
|---|---|
| Status: | new → closed |
#5374 covers the same issue, but is more up to date.
Note:
See TracTickets
for help on using tickets.
This patch is for the newforms-admin branch