Opened 7 years ago

Closed 6 years ago

#3222 closed enhancement (duplicate)

Add validators for all admin options

Reported by: Robert Myers <myer0052@…> Owned by: nobody
Component: contrib.admin Version: newforms-admin
Severity: normal Keywords:
Cc: myer0052@…, brosner@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


The file has a few validations for admin options. But not all options are being tested. Ticket #3217 provides tests to verify whether each validator is working properly.

Here is a list of the missing validators:

  • search_fields
  • js
  • save_as
  • save_on_top
  • list_select_related
  • list_per_page
  • fields
  • ordering
  • manager

Attachments (1)

3222-newforms-admin.patch (33.8 KB) - added by Robert Myers <myer0052@…> 7 years ago.
This patch is for the newforms-admin branch

Download all attachments as: .zip

Change History (8)

comment:1 Changed 7 years ago by Robert Myers <myer0052@…>

  • Type changed from defect to enhancement

comment:2 Changed 7 years ago by Robert Myers <myer0052@…>

  • Cc myer0052@… added

Changed 7 years ago by Robert Myers <myer0052@…>

This patch is for the newforms-admin branch

comment:3 Changed 7 years ago by Robert Myers <myer0052@…>

  • Has patch set
  • Triage Stage changed from Unreviewed to Design decision needed

I have attached a patch with complete tests for the newforms-admin branch. A design decision is needed because there are many changes. Also this patch fixes a minor error with the invalid_models test since the prepopulate_from option was moved.

comment:4 Changed 7 years ago by brosner <brosner@…>

  • Cc brosner@… added

comment:5 Changed 7 years ago by ubernostrum

  • Owner changed from nobody to jkocherhans
  • Version set to newforms-admin

Reassigning to jkocherhans since he's doing a lot of newforms-admin stuff.

comment:6 Changed 6 years ago by jkocherhans

  • Component changed from Core framework to Admin interface
  • Owner changed from jkocherhans to nobody
  • Triage Stage changed from Design decision needed to Accepted

I'm not actively working on this.

comment:7 Changed 6 years ago by jkocherhans

  • Resolution set to duplicate
  • Status changed from new to closed

#5374 covers the same issue, but is more up to date.

Add Comment

Modify Ticket

Change Properties
<Author field>
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'

E-mail address and user name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.