Opened 3 years ago

Closed 3 years ago

#32201 closed Cleanup/optimization (fixed)

remove obsolete isort:skip's

Reported by: Tim Graham Owned by: Seamus Quinn
Component: Core (Other) Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

Some isort:skip comments, particularly in the database backends (​example), are obsolete as of isort 5.0.

Change History (4)

comment:1 by Seamus Quinn, 3 years ago

Owner: changed from nobody to Seamus Quinn
Status: new → assigned

comment:2 by Mariusz Felisiak, 3 years ago

Triage Stage: Unreviewed → Accepted

seamus-quinn, please audit all isort:skip comments not only in django/db/backends (e.g. in django/template/__init__.py).

comment:3 by Mariusz Felisiak, 3 years ago

Has patch: set
Triage Stage: Accepted → Ready for checkin

​PR

comment:4 by GitHub <noreply@…>, 3 years ago

Resolution: → fixed
Status: assigned → closed

In 9f72b09:

Fixed #32201 -- Removed obsolete isort:skip's.

Obsolete as of isort 5.

Note: See TracTickets for help on using tickets.
Back to Top