Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#32155 closed New feature (invalid)

Count() by default uses group by

Reported by: Sukhinder Mann Owned by: nobody
Component: Database layer (models, ORM) Version: 2.2
Severity: Normal Keywords:
Cc: sukhinder.mann@… Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Sukhinder Mann)

I am trying to use Count() with Case to find out multiple conditional counts, and count keeps using id as default group by. I don't want it to use GROUP BY by default.

Staff.objects.filter(department__id__in=[2,3]).annotate(
                number_of_managers_in_UK=Sum(
                    Case(
                        When(position="MANAGER", location="UK", then=1),
                        output_field=IntegerField(),
                    )
                ),
                number_of_directors_in_USA=Sum(
                    Case(
                        When(position="DIRECTOR", location="USA", then=1),
                        output_field=IntegerField(),
                    )
                )
)

Which creates a SQL query something like this:

SELECT "staff"."id",
    "staff"."location",
    "staff"."position",
    "staff"."salary",
    "staff"."date_of_birth", -- I don't want all these other attributes as well but I can't get rid of these as well, I just need the count attributes
    COUNT(
        CASE
            WHEN "staff"."position" = MANAGER AND "staff"."location" = UK THEN 1
            ELSE NULL
        END
    ) AS "number_of_managers_in_UK",
    COUNT(
        CASE
            WHEN "staff"."position" = DIRECTOR AND "staff"."location" = USA THEN 1
            ELSE NULL
        END
    ) AS "number_of_directors_in_USA"
FROM "staff"
WHERE "staff"."department_id" IN (2, 3)
GROUP BY "staff"."id"; -- This group by is unnecessary and spoils the result set

Even though Count is an Aggregator function in SQL it can be used without GROUP BY. It would be good if we can have either a parameter or something to specify whether to use group by or not instead of defaulting to GROUP BY.

Change History (4)

comment:1 by Sukhinder Mann, 4 years ago

Type: UncategorizedNew feature

comment:2 by Sukhinder Mann, 4 years ago

Description: modified (diff)

comment:3 by Simon Charette, 4 years ago

Resolution: invalid
Status: newclosed

I think you're misunderstanding the annotate vs aggregate features of the ORM.

Annotations of aggregate functions have no choices but to group by the queryset's model to provide a result for each rows. If you want to perform an aggregation over filtered rows without grouping you'll want to use aggregate instead.

https://docs.djangoproject.com/en/3.1/topics/db/aggregation/

Please use support channels and consult documentation before filling a ticket next time as we use Trac solely for tracking feature requests and confirmed bugs.

https://code.djangoproject.com/wiki/TicketClosingReasons/UseSupportChannels

in reply to:  3 comment:4 by Sukhinder Mann, 4 years ago

Replying to Simon Charette:

I think you're misunderstanding the annotate vs aggregate features of the ORM.

Annotations of aggregate functions have no choices but to group by the queryset's model to provide a result for each rows. If you want to perform an aggregation over filtered rows without grouping you'll want to use aggregate instead.

https://docs.djangoproject.com/en/3.1/topics/db/aggregation/

Please use support channels and consult documentation before filling a ticket next time as we use Trac solely for tracking feature requests and confirmed bugs.

https://code.djangoproject.com/wiki/TicketClosingReasons/UseSupportChannels

Sorry for reporting a non-issue. This is completely my bad, you are correct I should have used aggregate and not annotate. Appreciate your help, thank you.

Note: See TracTickets for help on using tickets.
Back to Top