Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#32144 closed Bug (fixed)

makemessages leaves temporary files when locale directory doesn't exist.

Reported by: Anders Hovmöller Owned by: Anders Hovmöller
Component: Core (Management commands) Version: 3.1
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

If you run makemessages and you end up with the error message "Unable to find a locale path to store translations for file [...]", you get a lot of temporary files left over that you need to clean up.

The fix is pretty trivial so a PR is on the way.

Change History (7)

comment:1 by Anders Hovmöller, 4 years ago

Has patch: set

PR at ​https://github.com/django/django/pull/13609

comment:2 by Mariusz Felisiak, 4 years ago

Needs tests: set
Owner: changed from nobody to Anders Hovmöller
Patch needs improvement: set
Status: new → assigned
Summary: makemessages leaves temporary files in an error case → makemessages leaves temporary files when locale directory doesn't exist.
Triage Stage: Unreviewed → Accepted

comment:3 by Jacob Walls, 4 years ago

Needs tests: unset
Patch needs improvement: unset

Author updated patch with a test and seeks feedback on new approach.

comment:4 by Jacob Walls, 4 years ago

Triage Stage: Accepted → Ready for checkin

Verified regression test fails on main. Speaking of which, the regression test targets the additional case Anders found, so the title of the patch might be edited to be made more general, but I will leave that for others.

comment:6 by Carlton Gibson <carlton@…>, 4 years ago

Resolution: → fixed
Status: assigned → closed

In dfa77810:

Fixed #32144 -- Made makemessages remove temporary files when locale path doesn't exist.

comment:7 by Carlton Gibson <carlton@…>, 4 years ago

In 4af162d:

Refs #32144 -- Made makemessages remove temporary files on preprocessing error.

Co-authored-by: Anders Hovmöller <anders.hovmoller@…>

Note: See TracTickets for help on using tickets.
Back to Top