Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#32136 closed Bug (invalid)

Period inside of quoting in the deletion message

Reported by: Vlada Macek Owned by: nobody
Component: contrib.admin Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: yes

Description (last modified by Vlada Macek)

The sentence should end after the quoting ends in Admin. Not like this:

'Deleted “%(object)s.”'

but like this

'Deleted “%(object)s”.'

Including patch against master with all the PO files too. Please regenerate the MOs.

Attachments (1)

quotes.patch (20.3 KB ) - added by Vlada Macek 4 years ago.

Download all attachments as: .zip

Change History (7)

by Vlada Macek, 4 years ago

Attachment: quotes.patch added

comment:1 by Vlada Macek, 4 years ago

Description: modified (diff)

comment:3 by Mariusz Felisiak, 4 years ago

Has patch: unset
Resolution: invalid
Status: newclosed

Thanks for this ticket, however in American English, the punctuation usually goes inside the quote, see discussion.

comment:4 by Vlada Macek, 4 years ago

Incredible. This looks so strange...

So the line Added “%(object)s”. is probably incorrect and inconsistent...

comment:5 by Mariusz Felisiak, 4 years ago

Yes, there is another discussion (in which you were mentioned) to change other messages for consistency. Feel-free to send PR via GitHub.

comment:6 by Vlada Macek, 4 years ago

Oh, thank you. They mistyped my nickname in the mention, so I was unaware.

Yesterday I wanted to bring some clarity and less confusion to stuff. But I think I leave PR putting the punctuation inside quoting to someone who does not mind to follow the nonsensical American inertia-based rules from the long-gone ages of metallic typing.

Having period looking to be a part of the object representation distorts the object name. In my language (Czech) there is a sub-rule for inserted texts having no connection with the sentence, then we put period after the closing quotation.

Peace :-)

Note: See TracTickets for help on using tickets.
Back to Top