Opened 9 years ago

Closed 9 years ago

#3210 closed defect (fixed)

[patch] test-client Client.login() doesn't support absolute URLs in the Location header

Reported by: ben <ben.dean.kawamura@…> Owned by: russellm
Component: Tools Version:
Severity: normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Summary says it all. RFC 2616 specifies location headers should be absolute. I'm attaching a patch that fixes things for me.

Attachments (1)

test-client-absolute-urls.diff (1.1 KB) - added by ben <ben.dean.kawamura@…> 9 years ago.

Download all attachments as: .zip

Change History (6)

Changed 9 years ago by ben <ben.dean.kawamura@…>

comment:1 Changed 9 years ago by ben <ben.dean.kawamura@…>

  • Summary changed from Client.login() doesn't support absolute URLs in the Location header to [patch] Client.login() doesn't support absolute URLs in the Location header

comment:2 Changed 9 years ago by russellm

  • Owner changed from adrian to russellm

comment:3 Changed 9 years ago by SmileyChris

  • Triage Stage changed from Unreviewed to Ready for checkin

Looks straight-forward. Thanks ben.

comment:4 Changed 9 years ago by mtredinnick

  • Summary changed from [patch] Client.login() doesn't support absolute URLs in the Location header to [patch] test-client Client.login() doesn't support absolute URLs in the Location header

comment:5 Changed 9 years ago by russellm

  • Resolution set to fixed
  • Status changed from new to closed

(In [4540]) Fixed #3210 -- Modified test Client.login() to use urlparse, allowing absolute URLs in the Location header. Thanks, Ben Dean Kawamura.

Note: See TracTickets for help on using tickets.
Back to Top