Opened 10 years ago

Closed 10 years ago

#3210 closed defect (fixed)

[patch] test-client Client.login() doesn't support absolute URLs in the Location header

Reported by: ben <ben.dean.kawamura@…> Owned by: Russell Keith-Magee
Component: Tools Version:
Severity: normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Summary says it all. RFC 2616 specifies location headers should be absolute. I'm attaching a patch that fixes things for me.

Attachments (1)

test-client-absolute-urls.diff (1.1 KB) - added by ben <ben.dean.kawamura@…> 10 years ago.

Download all attachments as: .zip

Change History (6)

Changed 10 years ago by ben <ben.dean.kawamura@…>

comment:1 Changed 10 years ago by ben <ben.dean.kawamura@…>

Summary: Client.login() doesn't support absolute URLs in the Location header[patch] Client.login() doesn't support absolute URLs in the Location header

comment:2 Changed 10 years ago by Russell Keith-Magee

Owner: changed from Adrian Holovaty to Russell Keith-Magee

comment:3 Changed 10 years ago by Chris Beaven

Triage Stage: UnreviewedReady for checkin

Looks straight-forward. Thanks ben.

comment:4 Changed 10 years ago by Malcolm Tredinnick

Summary: [patch] Client.login() doesn't support absolute URLs in the Location header[patch] test-client Client.login() doesn't support absolute URLs in the Location header

comment:5 Changed 10 years ago by Russell Keith-Magee

Resolution: fixed
Status: newclosed

(In [4540]) Fixed #3210 -- Modified test Client.login() to use urlparse, allowing absolute URLs in the Location header. Thanks, Ben Dean Kawamura.

Note: See TracTickets for help on using tickets.
Back to Top