Make Token Generator more universal

[Ilya Chichak]

I suggest to split current PasswordResetTokenGenerator into BaseTokenGenerator and it's implementation PasswordResetTokenGenerator

To make BaseTokenGenerator more universal, it should contain class variable TOKEN_TIMEOUT with token timeout and _make_hash_value method public and abstract.

It will make possible to make email confirmation tokens, one time enter tokens and other with reimplementing make_hash_value method and setting separate timeout for each token generator. Current PasswordResetTokenGenerator will be implementation of BaseTokenGenerator where TOKEN_TIMEOUT will be settings.PASSWORD_RESET_TIMEOUT. So, for all logic, that uses PasswordResetTokenGenerator nothing will be changed.

​https://github.com/django/django/pull/13444

[Mariusz Felisiak]

Duplicate of #30423.

[Ilya Chichak]

@felixxm

In ticket you provided you said PasswordResetTokenGenerator is not universal.
So, I made BaseTokenGenerator that is more universal and flexible and not breaking current code.

Can I hear alternative opinion?

[Mariusz Felisiak]

Ilya, please continue a discussion in the original ticket and ​follow triaging guidelines with regards to wontfix tickets. You can start a discussion on DevelopersMailingList if you don't agree.