Changes between Initial Version and Version 1 of Ticket #32005


Ignore:
Timestamp:
Sep 15, 2020, 1:41:24 AM (4 years ago)
Author:
Carlton Gibson
Comment:

Hi Alex.

Thanks for the report. Perhaps need an extra coffee to think through if it's going to be worth the complexity but... — is this not a middleware ordering issue? i.e. If you put your HostDomainMiddleware before LocaleMiddleware would the response returned in process_request not get sent back to the client before LocaleMiddleware ever got the chance to look at it?

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #32005

    • Property Type Uncategorized → New feature

  • Ticket #32005 – Description

    initial v1  
    11This is related to the last two comments on #17734.  Specifically, if an application decides to return an explicit 404, there is no way to prevent the LocaleMiddleware from overriding this and trying the language redirect.
    22
    3 In those comments, it was about catch-all URL patterns.  I'm running into something related, but slightly different -- we [serve 404's for the `/` endpoint if the subdomain isn't valid](https://github.com/zulip/zulip/blob/master/zerver/middleware.py#L434), which the LocaleMiddleware unhelpfully redirects to (e.g.) `/en/` which isn't any less of a 404.
     3In those comments, it was about catch-all URL patterns.  I'm running into something related, but slightly different -- we [https://github.com/zulip/zulip/blob/master/zerver/middleware.py#L434 serve 404's for the `/` endpoint if the subdomain isn't valid], which the LocaleMiddleware unhelpfully redirects to (e.g.) `/en/` which isn't any less of a 404.
    44
    55Would folks be amenable to a patch which disabled the auto-404-redirect functionality in the middleware with a flag of some sort?
Back to Top