Opened 4 years ago
Last modified 4 years ago
#32005 closed New feature
Allow disabling of auto-404-redirection in LocaleMiddleware — at Version 1
| Reported by: | Alex Vandiver | Owned by: | nobody |
|---|---|---|---|
| Component: | Internationalization | Version: | 3.1 |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description (last modified by )
This is related to the last two comments on #17734. Specifically, if an application decides to return an explicit 404, there is no way to prevent the LocaleMiddleware from overriding this and trying the language redirect.
In those comments, it was about catch-all URL patterns. I'm running into something related, but slightly different -- we serve 404's for the `/` endpoint if the subdomain isn't valid, which the LocaleMiddleware unhelpfully redirects to (e.g.) /en/ which isn't any less of a 404.
Would folks be amenable to a patch which disabled the auto-404-redirect functionality in the middleware with a flag of some sort?
Change History (1)
comment:1 by , 4 years ago
| Description: | modified (diff) |
|---|---|
| Type: | Uncategorized → New feature |
Note:
See TracTickets
for help on using tickets.
Hi Alex.
Thanks for the report. Perhaps need an extra coffee to think through if it's going to be worth the complexity but... — is this not a middleware ordering issue? i.e. If you put your
HostDomainMiddlewarebeforeLocaleMiddlewarewould the response returned inprocess_requestnot get sent back to the client beforeLocaleMiddlewareever got the chance to look at it?