Changes between Initial Version and Version 1 of Ticket #31983


Ignore:
Timestamp:
Sep 5, 2020, 12:50:51 PM (4 years ago)
Author:
Johannes Maron
Comment:

Hi there,

You are making an excellent point. Since this seems to be your first code contribution, I recommend checking out the contribution guidelines to get you kick-started.

Beyond that, I will do a review of your patch. Of the bat I can tell you that tests are missing. You will find examples for how to write a test by reviewing the tests for similar checks.

Let me know if you need any pointers.

Best, Joe

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #31983

    • Property Cc Johannes Maron added
    • Property Component Testing framework → Core (Cache system)
    • Property Easy pickings set
    • Property Patch needs improvement set
    • Property Needs documentation set
    • Property Needs tests set
    • Property Triage Stage Unreviewed → Accepted
    • Property Summary Add security check for cache location → Add a warning if the file system cache location is within the static or media roots
    • Property Type Uncategorized → Cleanup/optimization
    • Property Version 3.1 → master

  • Ticket #31983 – Description

    initial v1  
    1 Hi, I have been reported an issue to security team one month ago. And the final conclusion is to check whether filesystem cache's  location is  a sub directory of special location.
     1Hi,
     2
     3I have been reported an issue regarding the file system cache location to security team one month ago. And the conclusion is to check whether file system cache's  location is  a subdirectory of special location.
    24
    35I wrote a check function and require a ticket to make a PR.
Back to Top