Opened 4 years ago

Closed 4 years ago

#31978 closed Bug (fixed)

Include hidden username field on password reset to help password managers

Reported by: Collin Anderson Owned by: Mariusz Felisiak
Component: contrib.admin Version: dev
Severity: Release blocker Keywords:
Cc: cmawebsite@…, Collin Anderson Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Include hidden username field on password reset to help password managers

https://github.com/django/django/pull/13327

Change History (11)

comment:1 by Collin Anderson, 4 years ago

Cc: Collin Anderson added

comment:2 by Mariusz Felisiak, 4 years ago

Component: contrib.authcontrib.admin
Needs tests: set
Owner: changed from nobody to Collin Anderson
Status: newassigned
Triage Stage: UnreviewedAccepted
Type: New featureCleanup/optimization

Sounds reasonable.

comment:3 by Mariusz Felisiak, 4 years ago

Needs tests: unset
Triage Stage: AcceptedReady for checkin

comment:4 by Mariusz Felisiak <felisiak.mariusz@…>, 4 years ago

Resolution: fixed
Status: assignedclosed

In daa26ac:

Fixed #31978 -- Added username hint to admin's password reset confirmation form.

comment:5 by Jaap Roes, 4 years ago

I just came across this by chance and noticed that <input style="display: none;" autocomplete="username" value="{{ form.user.username }}"> is used in the template. Shouldn't form.user.get_username be used here? In my custom User model the username field is ommited, only email exists, and User.USERNAME_FIELD is set to email.

comment:6 by Collin Anderson, 4 years ago

Patch needs improvement: set
Resolution: fixed
Severity: NormalRelease blocker
Status: closednew

My bad. That sounds right, this will break for anyone who has a custom USERNAME_FIELD.

comment:7 by Collin Anderson, 4 years ago

Triage Stage: Ready for checkinAccepted
Type: Cleanup/optimizationBug

comment:8 by Mariusz Felisiak, 4 years ago

Owner: changed from Collin Anderson to Mariusz Felisiak
Status: newassigned

comment:9 by Mariusz Felisiak, 4 years ago

Patch needs improvement: unset

comment:10 by Mariusz Felisiak <felisiak.mariusz@…>, 4 years ago

In 3828427f:

Refs #31978 -- Fixed hint in admin's password reset confirmation form for custom username fields.

Thanks Jaap Roes for the report.

comment:11 by Mariusz Felisiak, 4 years ago

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.
Back to Top