[patch] generic date_based view, allowing week to start on monday

[nicolaslara@…]

I found a bit contradictory that the date filter believes weeks start on Monday while generic date_based views believe weeks start on Sunday.
Here is a patch to the date_based generic view to allow an extra argument week_starts_monday=False that, if true, makes the weeks start on monday.
(its pretty straight forward)

[nicolaslara@…]

date_based.py.diff

[Simon G. <dev@…>]

Is it possible to change this from the rather restrictive "week_starts_monday" to a generic "week_start_day" option?

[anonymous]

Related ticket: ​http://code.djangoproject.com/ticket/1061
Perhaps it would be exported to admin view

[jgomo3]

Replying to mir@noris.de:

Justo to comment that the format of strptime support a directive to express the number of a week with monday beeing the first day of the week: it is %W. So, if week_starts_monday is False the line wich define tha local var date states unchanged like this:

date = datetime.date(*time.strptime(year+'-0-'+week, '%Y-%w-%U')[:3])

but if week_starts_monday is True, it can be changed to:

date = datetime.date(*time.strptime(year+'-0-'+week, '%Y-%w-%W')[:3])

I think it is cleaner than adding a day to date.

[jgomo3]

Also has to be changed the number representing the day of the week (%w). So, the stuff is like, for sunday beeing the first day:

date = datetime.date(*time.strptime(year+'-0-'+week, '%Y-%w-%U')[:3])

but for monday beeing the first day:

date = datetime.date(*time.strptime(year+'-1-'+week, '%Y-%w-%W')[:3])

I think that's all.

[jgomo3]

Calendar based archive_week generic view.

[jgomo3]

Replying to Simon G. <dev@simon.net.nz>:

Is it possible to change this from the rather restrictive "week_starts_monday" to a generic "week_start_day" option?

Yes. I did this patch (​date_based.py.2.diff) to prove the concept and i let it in my django install. The generic option would be firstweekday. Is based on the python standar calendar module, wich define tha Calendar class wich by default set monday as the first week day, but let you specify one of the seven days of the week as the first day (0 is monday and 6 is sunday).

Note: but, i think people is working on this issue and more here #7980, and maybe this ticket should be closed and the diff's should be exported to the #7980.

[Russell Keith-Magee]

Accepted on the basis that we now have USE_L10N, which this view should be honoring.

[Russell Keith-Magee]

Also needs to be updated for class-based views.

[Aymeric Augustin]

Change UI/UX from NULL to False.

[Aymeric Augustin]

Change Easy pickings from NULL to False.

[Aymeric Augustin]

It seems to me that WeekMixin.week_format provides this feature in the class-based generic views. The function-based generic views no longer exist.