Opened 5 years ago

Closed 5 years ago

#31884 closed Cleanup/optimization (wontfix)

nav-sidebar ui optimization

Reported by: 007 Owned by: nobody
Component: contrib.admin Version: 3.1
Severity: Normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by 007)

1：toggle-nav-sidebar will got a black border after click in chrome;
https://code.djangoproject.com/raw-attachment/ticket/31884/1.png
2：content will Out of screen when nav-sidebar is open
https://code.djangoproject.com/raw-attachment/ticket/31884/2.png

Attachments (2)

1.png​ (5.9 KB ) - added by 007 5 years ago.
2.png​ (35.9 KB ) - added by 007 5 years ago.

Download all attachments as: .zip

Change History (6)

by 007, 5 years ago

Attachment: 1.png​ added

by 007, 5 years ago

Attachment: 2.png​ added

comment:1 by 007, 5 years ago

Description: modified (diff)

comment:2 by Tom Carrick, 5 years ago

Fixing the first issue isn't desirable. The border is there for :focus I believe, which is necessary for knowing where you are as you tab through the page, it's necessary for keyboard users. If there's a way to fix it without losing this, then maybe... but the current PR doesn't.

comment:3 by 007, 5 years ago

rollback to button and add blur() when mouseup

comment:4 by Carlton Gibson, 5 years ago

Resolution: → wontfix
Status: assigned → closed

I'll close the issue here. If there's an optimisation that we want from the discussion in the PR we can take it as Refs #31034 -- ...

Note: See TracTickets for help on using tickets.
Back to Top