test_extraction_warning (i18n.test_extraction.BasicExtractorTests) fails with xgettext 0.21.

[Michał Górny]

After upgrading system gettext to 0.21, the following test started to fail:

======================================================================
FAIL: test_extraction_warning (i18n.test_extraction.BasicExtractorTests)
test xgettext warning about multiple bare interpolation placeholders
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python3.9/unittest/case.py", line 59, in testPartExecutor
    yield
  File "/usr/lib/python3.9/unittest/case.py", line 593, in run
    self._callTestMethod(testMethod)
  File "/usr/lib/python3.9/unittest/case.py", line 550, in _callTestMethod
    method()
  File "/tmp/django/tests/i18n/test_extraction.py", line 233, in test_extraction_warning
    self.assertIn("code_sample.py:4", out.getvalue())
  File "/usr/lib/python3.9/unittest/case.py", line 1098, in assertIn
    self.fail(self._formatMessage(msg, standardMsg))
  File "/usr/lib/python3.9/unittest/case.py", line 670, in fail
    raise self.failureException(msg)
AssertionError: 'code_sample.py:4' not found in 'processing locale de\n'

I can reproduce the failure with django 2.2.15, 3.0.9 and git master (b68b8cb89abb35ff2152175ea540619ec384b1f4).

[Mariusz Felisiak]

I confirmed test failure with xgettext 0.21, it passes with the version 0.19.8.1. We can skip this test on specific versions of xgettext. Do you know when exactly it stopped to warn about multiple bare placeholders? Changelog would be helpful.

[Mariusz Felisiak]

We should use a message that will cause a xgettext warning in all versions, see #18479.

[Sicong]

I'll try to work on this issue.

[Sicong]

I can also reproduce this error.
I looked a little bit into gettext's source code, under warn_format_string function in xg-message.c. Everything seems fine. I'm not sure why xgettext not giving this warning. I'll leave this to somebody with more experience.

[Ira]

I will try to work on this issue.

[Ira]

Can someone above help me reproduce the error? Please let me know iraf333@…

[Ira]

I am going to release this ticket

[Max Smolens]

It looks like xgettext 0.21 has a bug where the "format string with unnamed arguments cannot be properly localized" warning is not displayed. I proposed a patch upstream and am awaiting confirmation from the maintainer.

Regardless, I created a patch to use a message that causes an xgettext warning in all versions, as suggested by comment:2.

[Mariusz Felisiak]

​PR

[Mariusz Felisiak <felisiak.mariusz@…>]

In 07a30f56:

Fixed #31850 -- Fixed BasicExtractorTests.test_extraction_warning with xgettext 0.21+.

"format string with unnamed arguments cannot be properly localized"
warning is not raised in xgettext 0.21+.

This patch uses a message that causes an xgettext warning regardless of
the version.

[Michał Górny]

I can confirm that the patch fixes the issue for me. Thanks!

[Michał Górny]

Would it be possible to backport this into 2.2, 3.0 and 3.1 branches?

[Mariusz Felisiak <felisiak.mariusz@…>]

In e707a1bd:

[3.1.x] Fixed #31850 -- Fixed BasicExtractorTests.test_extraction_warning with xgettext 0.21+.

"format string with unnamed arguments cannot be properly localized"
warning is not raised in xgettext 0.21+.

This patch uses a message that causes an xgettext warning regardless of
the version.

Backport of 07a30f561661efae1691ff45d10ec6014b395b58 from master

[Mariusz Felisiak <felisiak.mariusz@…>]

In c506639b:

[3.0.x] Fixed #31850 -- Fixed BasicExtractorTests.test_extraction_warning with xgettext 0.21+.

"format string with unnamed arguments cannot be properly localized"
warning is not raised in xgettext 0.21+.

This patch uses a message that causes an xgettext warning regardless of
the version.

Backport of 07a30f561661efae1691ff45d10ec6014b395b58 from master

[Mariusz Felisiak <felisiak.mariusz@…>]

In e893c0ad:

[2.2.x] Fixed #31850 -- Fixed BasicExtractorTests.test_extraction_warning with xgettext 0.21+.

"format string with unnamed arguments cannot be properly localized"
warning is not raised in xgettext 0.21+.

This patch uses a message that causes an xgettext warning regardless of
the version.

Backport of 07a30f561661efae1691ff45d10ec6014b395b58 from master

[Mariusz Felisiak]

Replying to Michał Górny:

Would it be possible to backport this into 2.2, 3.0 and 3.1 branches?

Backported.

[Michał Górny]

That was fast. Thank you!