xgettext warnings cause the makemessages command to raise an exception

[anonymous]

Related to ticket #7564, in that the messages thrown are the same.

System: Macbook Pro, Lion OS, Django 1.4, Python 2.7.3, xgettext 0.18.1

Still seeing the error:

Error: errors happened while running xgettext on models.py ./myproject/models.py:177: warning: 'msgid' format string with unnamed arguments cannot be properly localized:

The translator cannot reorder the arguments. Please consider using a format string with named arguments, and a mapping instead of a tuple for the arguments.

This happens because xgettext will still throw a warning, which will be catch by the "if errors:" block in makemessages.py. Inside the block, we will then raise an exception, regardless of whether or not this error is a fatal error or not. Suggest fix to at least look at the error level (info,warning, error, etc.) and only raise an exception if the error is fatal.

[Claude Paroz]

Agreed, we should only raise CommandError if the status code of the executed command is != 0. The _popen function should get and return p.returncode.

[Niels Sandholt Busch]

I added a pull request for this ticket here: ​https://github.com/nsb/django/tree/ticket_18479

[Claude Paroz <claude@…>]

In [c54905b3597545dbe1a6d8cd0a60186bccf8b3e7]:

Fixed #18479 -- Stopped makemessages raising error on gettext warnings

Thanks Niels Busch for the initial patch.