Opened 3 years ago

Closed 3 years ago

#31825 closed Cleanup/optimization (fixed)

RenameField with db_column should be a noop.

Reported by: Iuri de Silvio Owned by: Iuri de Silvio
Component: Migrations Version: dev
Severity: Normal Keywords:
Cc: Simon Charette Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Iuri de Silvio)

RenameField with db_column should be a noop because it is only the Django column that changed, the database still have the same db_column.

Change History (11)

comment:1 Changed 3 years ago by Iuri de Silvio

Description: modified (diff)
Summary: RenameField with db_column defined drop and recreate the same constrainsts → RenameField with db_column defined drop and recreate the same constrainsts on Postgres

comment:2 Changed 3 years ago by Iuri de Silvio

I did a pull request here. ​https://github.com/django/django/pull/13236

comment:3 Changed 3 years ago by Iuri de Silvio

Owner: changed from nobody to Iuri de Silvio
Status: new → assigned

comment:4 Changed 3 years ago by Iuri de Silvio

Version: 3.0 → master

comment:5 Changed 3 years ago by Mariusz Felisiak

Cc: Simon Charette added
Has patch: set
Summary: RenameField with db_column defined drop and recreate the same constrainsts on Postgres → RenameField with db_column should be a noop.
Triage Stage: Unreviewed → Accepted

Thanks. See related ticket where Simon pointed out that such change (3 & 4) should be a noop.

Last edited 3 years ago by Mariusz Felisiak (previous) (diff)

comment:6 Changed 3 years ago by Mariusz Felisiak

Patch needs improvement: set

comment:7 Changed 3 years ago by Iuri de Silvio

Patch needs improvement: unset

comment:8 Changed 3 years ago by Mariusz Felisiak

Patch needs improvement: set

comment:9 Changed 3 years ago by Iuri de Silvio

Patch needs improvement: unset

comment:10 Changed 3 years ago by Mariusz Felisiak

Triage Stage: Accepted → Ready for checkin

comment:11 Changed 3 years ago by Mariusz Felisiak <felisiak.mariusz@…>

Resolution: → fixed
Status: assigned → closed

In 7f4c9222:

Fixed #31825 -- Made RenameField operation a noop for fields with db_column.

Note: See TracTickets for help on using tickets.
Back to Top