Opened 18 years ago
Closed 18 years ago
#3181 closed enhancement (duplicate)
[patch] list_detail.object_list doesn't support custom querysets
Reported by: | Owned by: | Jacob | |
---|---|---|---|
Component: | Generic views | Version: | |
Severity: | minor | Keywords: | |
Cc: | Triage Stage: | Unreviewed | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
It'd be great if the generic object paginator view (list_detail.object_list
) would accept a custom queryset (as described in the custom model Manager docs here) -- that is, a list of fully-fetched model objects.
The backend of the view (paginator.ObjectPaginator
) has explicit support for lists, but object_list calls queryset._clone
which fails for list objects.
Attachments (2)
Change History (7)
by , 18 years ago
Attachment: | list_detail.patch.txt added |
---|
comment:1 by , 18 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Summary: | list_detail.object_list doesn't support custom querysets → [patch] list_detail.object_list doesn't support custom querysets |
Proposed patch which checks to see if the queryset we passed in is a queryset, otherwise, we assume it's a list.
Other generic paged-views (date_based, object_detail) still assume a queryset.
comment:2 by , 18 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Ug. Sorry. Wrong fields checked by accident
comment:3 by , 18 years ago
Resolution: | → duplicate |
---|---|
Status: | reopened → closed |
comment:4 by , 18 years ago
Resolution: | duplicate |
---|---|
Status: | closed → reopened |
Please specify the ticket this duplicates.
comment:5 by , 18 years ago
Resolution: | → duplicate |
---|---|
Status: | reopened → closed |
ok, this seems to be a duplicate of #3168.
Patch for list_detail