Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#31791 closed New feature (fixed)

Make technical 404 page always show tried URL patterns

Reported by: Jon Dufresne Owned by: Jon Dufresne
Component: Error reporting Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Right now, the technical 404 page (shown in DEBUG mode) shows the URL patterns when a URL is not matched. This is quite handy for debugging, as it helps show why a URL resulted in a 404. However, when a URL is matched and the view raises Http404, this information is not shown. I'm suggesting we show all URLs that were tried up to the point of resolution of the URL to provide more debugging info.

(Extracted from ​https://github.com/django/django/pull/13134)

Change History (8)

comment:2 by Carlton Gibson, 4 years ago

Thanks Jon. This looked like a nice win when I glanced at it before, so very happy to take this for review. 👍

comment:3 by Carlton Gibson, 4 years ago

Triage Stage: Unreviewed → Accepted

comment:4 by Nick Pope, 4 years ago

Owner: set to Jon Dufresne
Status: new → assigned

comment:5 by Mariusz Felisiak, 4 years ago

Patch needs improvement: set

comment:6 by Jon Dufresne, 4 years ago

Patch needs improvement: unset

comment:7 by Mariusz Felisiak <felisiak.mariusz@…>, 4 years ago

Resolution: → fixed
Status: assigned → closed

In 11ebc647:

Fixed #31791 -- Made technical 404 debug page display the tried URL patterns for Http404.

comment:8 by GitHub <noreply@…>, 4 years ago

In 622fcb8:

Refs #31791 -- Improved performance of URLResolver.resolve().

Performance regression in 11ebc6479ffda87376b60c9475d33d8120f86368.

Note: See TracTickets for help on using tickets.
Back to Top