Opened 4 weeks ago

Last modified 3 weeks ago

#31777 assigned New feature

Custom collations

Reported by: Tom Carrick Owned by: Tom Carrick
Component: Database layer (models, ORM) Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Tom Carrick)

Mailing list, but it didn't get any responses: https://groups.google.com/u/2/g/django-developers/c/djMQwwxtCVY

We have the various CI fields on postgres, but these are discouraged since pg12 in favour of nondeterministic collations. I think it'd be useful to have a way to do this in Django, though I'm not sure what the API would look like. My initial thought, knowing very little about the ORM, is a Collation class that can be passed into a model field, but I'm not sure.

PR

Change History (9)

comment:1 Changed 4 weeks ago by Simon Charette

Related to #21181, #9682, and #5745.

comment:2 Changed 4 weeks ago by Carlton Gibson

Resolution: needsinfo
Status: newclosed

Mailing list, but it didn't get any responses...

Hi Tom. I feel bad saying you need to go back to the mailing list, but without SOME proposal this isn't really actionable as it stands.

You've got Simon's attention now, so there's hope there... 🙂

Short of that, I'd suggest sketching up some ideas and following up your initial post. (Having just looked at it, it's a bit "Argh! no idea", at first glance.)

I'm going to close as needs info for now. Really happy to re-open either we have some suggestions for the API, or (less good) we're happy to leave it open even undefined, but then I'd probably want to mark it Someday/Maybe. I hope that makes sense.

comment:3 Changed 3 weeks ago by Aymeric Augustin

Resolution: needsinfo
Status: closednew

Hello Carlton, given that there's a PR that looks quite reasonable and a bit of support on the mailing list, I'm going to reopen and accept.

The ticket was short on details; the PR makes things clearer.

Essentially this is adding ORM support for a feature that most databases support. I'm not seeing obvious drawbacks. Hence, accepting.

comment:4 Changed 3 weeks ago by Aymeric Augustin

Triage Stage: UnreviewedAccepted

comment:5 Changed 3 weeks ago by Carlton Gibson

Super. Thanks!

comment:6 Changed 3 weeks ago by Tom Carrick

Owner: changed from nobody to Tom Carrick
Status: newassigned

comment:7 Changed 3 weeks ago by Tom Carrick

Description: modified (diff)
Has patch: set

comment:8 Changed 3 weeks ago by Tom Carrick

Triage Stage: AcceptedReady for checkin

comment:9 Changed 3 weeks ago by felixxm

Triage Stage: Ready for checkinAccepted

You shouldn't mark you own PRs as ready for checkin.

Note: See TracTickets for help on using tickets.
Back to Top