Opened 4 years ago
Closed 4 years ago
#31691 closed New feature (fixed)
Added ordering support to JSONBAgg.
Reported by: | john-parton | Owned by: | john-parton |
---|---|---|---|
Component: | contrib.postgres | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description (last modified by )
Here's a contrived example:
class Author(models.Model): name = models.CharField(max_length=50) alias = models.CharField(max_length=50, null=True, blank=True) age = models.PositiveSmallIntegerField(default=30) class Article(models.Model): authors = models.ManyToManyField(Author, related_name='articles') title = models.CharField(max_length=50) Article.objects.annotate( authors_json=JSONBAgg( Func( Value('name'), 'name', Value('alias'), 'alias', function='jsonb_build_object' ), ordering='age' ) )
The ordering kwarg is ignored, but Postgres would have no problem understanding the aggregate with an ORDER BY clause
In my code I did the following
class OrderableJSONBAgg(OrderableAggMixin, Aggregate): function = 'JSONB_AGG' template = '%(function)s(%(expressions)s %(ordering)s)' output_field = JSONField() def convert_value(self, value, expression, connection): if not value: return [] return value from myapp.aggregates import OrderableJSONBAgg as JSONBAgg
I believe replacing the existing JSONBAgg with this implementation would add the feature, with no backwards compat issues.
I would be happy to submit a pull request.
Change History (8)
comment:1 by , 4 years ago
Description: | modified (diff) |
---|
comment:2 by , 4 years ago
Description: | modified (diff) |
---|
comment:3 by , 4 years ago
Description: | modified (diff) |
---|
comment:4 by , 4 years ago
Description: | modified (diff) |
---|
comment:5 by , 4 years ago
Component: | Database layer (models, ORM) → contrib.postgres |
---|---|
Summary: | django.contrib.postgres.aggregates.JSONBAgg does not support ordering → Added ordering support to JSONBAgg. |
Triage Stage: | Unreviewed → Accepted |
Version: | 3.0 → master |
comment:6 by , 4 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
Sure. I think I can handle it.
Note:
See TracTickets
for help on using tickets.
Would you like to prepare a patch? (see similar patch 96199e562dcc409ab4bdc2b2146fa7cf73c7c5fe for
ArrayAgg
andStringAgg
).