Opened 6 years ago

Last modified 3 weeks ago

#31613 new Bug

GeoModelAdmin's openlayers widget stroke width too thin for some linestrings

Reported by: Vincent Ahrend Owned by: nobody
Component: GIS Version: 3.0
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The openlayers widget, which is used by GeoModelAdmin to display geometries of model fields, is configured to display geometries of the linestring type with a thicker stroke width than other geometries. However, this only work if the geometry is not stored as a generic geometry, but specifically as a linestring.

As the editor becomes unusable in this case - when linestring geometries are stored as generic geometries - and other geometries are still displayed in a usable manner, I propose applying the thicker stroke width to all generic geometries as well.

I would like to attach screenshots to illustrate the problem but I can't find documentation on how to do so.

I am a first-time contributor and would love to submit a pull request for this but I am not sure of the correct procedure. If I open a pull request how do I properly connect it to this ticket?

Change History (3)

comment:1 by Carlton Gibson, 6 years ago

Triage Stage: Unreviewed → Accepted

Hi Vincent.

Thanks for the report. I'll accept this based on your comments, but if you could upload screenshots, that would help other coming to read this.

There's a "Attachments" section just above the form to edit the issue description where you can attach files.
(You can do inline images too.)

​Here's a guide to submitting patches.

comment:2 by Mariusz Felisiak, 6 years ago

Has patch: unset

comment:3 by Dmitri, 3 weeks ago

The code this ticket refers to (strokeWidth = 3 for linestrings in gis/admin/openlayers.js) was removed together with GeoModelAdmin/OSMGeoAdmin in Django 5.0. The current OLMapWidget.js used by GISModelAdmin applies the default OpenLayers style uniformly to all geometry types, so the inconsistency described here no longer exists. Suggest closing as wontfix/invalid.

Note: See TracTickets for help on using tickets.
Back to Top