Opened 5 years ago

Last modified 5 years ago

#31613 new Bug

GeoModelAdmin's openlayers widget stroke width too thin for some linestrings

Reported by: Vincent Ahrend Owned by: nobody
Component: GIS Version: 3.0
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no
Pull Requests:How to create a pull request

Description

The openlayers widget, which is used by GeoModelAdmin to display geometries of model fields, is configured to display geometries of the linestring type with a thicker stroke width than other geometries. However, this only work if the geometry is not stored as a generic geometry, but specifically as a linestring.

As the editor becomes unusable in this case - when linestring geometries are stored as generic geometries - and other geometries are still displayed in a usable manner, I propose applying the thicker stroke width to all generic geometries as well.

I would like to attach screenshots to illustrate the problem but I can't find documentation on how to do so.

I am a first-time contributor and would love to submit a pull request for this but I am not sure of the correct procedure. If I open a pull request how do I properly connect it to this ticket?

According to the ticket's flags, the next step(s) to move this issue forward are:

  • To provide a patch by sending a pull request. Claim the ticket when you start working so that someone else doesn't duplicate effort. Before sending a pull request, review your work against the patch review checklist. Check the "Has patch" flag on the ticket after sending a pull request and include a link to the pull request in the ticket comment when making that update. The usual format is: [https://github.com/django/django/pull/#### PR].

Change History (2)

comment:1 by Carlton Gibson, 5 years ago

Triage Stage: UnreviewedAccepted

Hi Vincent.

Thanks for the report. I'll accept this based on your comments, but if you could upload screenshots, that would help other coming to read this.

There's a "Attachments" section just above the form to edit the issue description where you can attach files.
(You can do inline images too.)

Here's a guide to submitting patches.

comment:2 by Mariusz Felisiak, 5 years ago

Has patch: unset
Note: See TracTickets for help on using tickets.
Back to Top