Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#31603 closed Bug (fixed)

"Clear all filters" link removes ordering and search criteria.

Reported by: Mariusz Felisiak Owned by: nobody
Component: contrib.admin Version: 3.1
Severity: Release blocker Keywords:
Cc: frnhr Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

"Clear all filters" link removes ordering and search criteria, it should clear only filters. It is a new feature added in Django 3.1 (see #27888 and b94764e178056a2118eff3f53f567207219e737d.

​Discussion on the mailing list.

Thanks Fran Hrženjak for the report.

Change History (5)

comment:1 by Hasan Ramezani, 5 years ago

@felixxm
I've just created a ​PR to fix this ticket. not sure about the solution.
I can complete the PR and add more tests if you are OK with the proposed solution.

comment:2 by Mariusz Felisiak, 5 years ago

Has patch: set

​New PR

comment:3 by Mariusz Felisiak, 5 years ago

Triage Stage: Accepted → Ready for checkin

comment:4 by Mariusz Felisiak <felisiak.mariusz@…>, 5 years ago

Resolution: → fixed
Status: new → closed

In 4484bc1b:

Fixed #31597, #31603 -- Corrected admin clear all filters link behavior.

  • Show "Clear all filters" only when any filter is selected.
  • Preserve query string not related with filters.

Co-Authored-By: Hasan Ramezani <hasan.r67@…>

comment:5 by Mariusz Felisiak <felisiak.mariusz@…>, 5 years ago

In 47e21d33:

[3.1.x] Fixed #31597, #31603 -- Corrected admin clear all filters link behavior.

  • Show "Clear all filters" only when any filter is selected.
  • Preserve query string not related with filters.

Co-Authored-By: Hasan Ramezani <hasan.r67@…>

Backport of 4484bc1b2f84da6442c9c2bfd95d3f1f7d8f96f7 from master

Note: See TracTickets for help on using tickets.
Back to Top