Replace Command.requires_system_checks = True by something like Command.required_system_checks = '__all__'

[Hasan Ramezani]

Created based on Simon ​comment on the PR

This makes me wonder if we want to replace Command.requires_system_checks = True by something like Command.required_system_checks = '__all__' that can be set to an empty list to achieve required_system_checks = False and allow subclasses that want only a subset to specify tags through it e.g. required_system_checks = ['staticfiles']. That would prevent having do to the manual and error prone options['skip_checks'] dance. In all cases that should be done in a different PR.

[Carlton Gibson]

OK, accepting based on the discussion on the PR. Thanks!

[Hasan Ramezani]

I created a ​PR for start.
Should we go for deprecating the requires_system_checks = True/False?

[Mariusz Felisiak]

Replying to Hasan Ramezani:

I created a ​PR for start.
Should we go for deprecating the requires_system_checks = True/False?

Yes.

[Carlton Gibson <carlton.gibson@…>]

In c60524c6:

Fixed #31546 -- Allowed specifying list of tags in Command.requires_system_checks.

[Mariusz Felisiak <felisiak.mariusz@…>]

In 1cb4950:

Refs #31546 -- Removed support for boolean values in Command.requires_system_checks.

Per deprecation timeline.

[GitHub <noreply@…>]

In 829f4d1:

Refs #31546, Refs #34118 -- Corrected CommandTests.test_requires_system_checks_specific().

System checks are never called without skip_checks=False. Moreover,
called_once_with() is not a proper assertion and raise AttributeError
on Python 3.12.