Opened 10 years ago

Closed 10 years ago

Last modified 7 years ago

#3152 closed enhancement (invalid)

[patch] Changed a few things in admin to allow overiding of list_per_page in admin

Reported by: Ben Ford <ben.fordnz@…> Owned by: Adrian Holovaty
Component: contrib.admin Version: master
Severity: normal Keywords: paginator admin change_list
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: UI/UX:

Description

As per my post on django-developers here I've made a few changes to the ChangeList object (among other things) to add a field for specifying the number per page to show in the change_list view in admin.

The patch is against 4077 I'm afraid... I'm not yet comfortable with SVN to be all that confident about updating without shooting myself in the foot!

This patch also contains changes I've made to fix admin breaking when sorting on a FK with has an order_by specified as -something.

Attachments (1)

number_per_page.diff (16.6 KB) - added by Ben Ford <ben.fordnz@…> 10 years ago.

Download all attachments as: .zip

Change History (7)

Changed 10 years ago by Ben Ford <ben.fordnz@…>

Attachment: number_per_page.diff added

comment:1 Changed 10 years ago by Ben Ford <ben.fordnz@…>

Ok, it looks like I've screwed up the diff slightly, but I hope it's enough to get the idea!

comment:2 Changed 10 years ago by ramiro <rm0 _at_ gmx.net>

Ben,

Would you mind unfolding you proposed mods in two patches?: One implementing the feature you describe and attaching it to this ticket an another implementing the "This patch also contains changes I've made to fix admin breaking when sorting on a FK with has an order_by specified as -something." fix possibly creating a different ticket for that?.

It would make things easier fot the bug reviewers and it may raise the possibility of it being applied/closed/marked as duplicate/etc.

comment:3 Changed 10 years ago by Chris Beaven

Patch needs improvement: set
Resolution: invalid
Status: newclosed

I'll close this enhancement request for now. If Ben or someone else wants to write a new patch, feel free to reopen.

comment:4 Changed 10 years ago by ben

I'm happy to re-do the patch... Could you indicate hat was wrong with it so I can fix it?

comment:5 Changed 10 years ago by Chris Beaven

Good to hear, Ben. Start with Ramiro's suggestions and reopen with the new patch - thanks!

comment:6 Changed 7 years ago by shoyer

Related: #4065

Note: See TracTickets for help on using tickets.
Back to Top