Opened 5 years ago

Closed 5 years ago

#31470 closed Cleanup/optimization (fixed)

Overflow not respected when using `<pre>` tag in `<fieldset>` in the admin site.

Reported by: Nick Pope Owned by: Nick Pope
Component: contrib.admin Version: dev
Severity: Normal Keywords: admin, fieldset, pre, overflow
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: yes

Description

When using the <pre> tag to render a read-only block of code/markup with syntax highlighting in a <fieldset>, overflow is not respected and the <pre> forces the <fieldset> to be wider.

This can be resolved by setting min-width: 0 on fieldset in CSS.

Attachments (2)

without-fix.png​ (52.9 KB ) - added by Nick Pope 5 years ago.
with-fix.png​ (52.9 KB ) - added by Nick Pope 5 years ago.

Download all attachments as: .zip

Change History (6)

by Nick Pope, 5 years ago

Attachment: without-fix.png​ added

by Nick Pope, 5 years ago

Attachment: with-fix.png​ added

comment:1 by Nick Pope, 5 years ago

Has patch: set

​PR

comment:2 by Mariusz Felisiak, 5 years ago

Triage Stage: Unreviewed → Accepted
Type: Uncategorized → Cleanup/optimization

Thanks, I reproduced this issue.

comment:3 by Mariusz Felisiak, 5 years ago

Triage Stage: Accepted → Ready for checkin

comment:4 by Carlton Gibson <carlton@…>, 5 years ago

Resolution: → fixed
Status: assigned → closed

In daabb102:

Fixed #31470 -- Fixed fieldset admin CSS to prevent overflowing <pre> elements.

Co-Authored-By: Mariusz Felisiak <felisiak.mariusz@…>

Note: See TracTickets for help on using tickets.
Back to Top