Opened 3 years ago

Closed 2 years ago

#31370 closed New feature (fixed)

Make parallel test runner work with buffer option.

Reported by: Adam Johnson Owned by: Adam Johnson
Component: Testing framework Version: dev
Severity: Normal Keywords:
Cc: Baptiste Mispelon Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

#27430 added support for unittest's --buffer option, but only when not using --parallel. Since --parallel is normally very useful to speed up tests, it would be good to make the options work together. I think this can be done by copying some code from unittest into the RemoteTestResult class.

Change History (12)

comment:1 Changed 3 years ago by Mariusz Felisiak

Cc: Baptiste Mispelon added
Resolution: → needsinfo
Status: assigned → closed
Summary: Make parallel test runner work with buffer option → Make parallel test runner work with buffer option.

I'm not sure if it's feasible (see comment). I think we need a proof of concept, before we will accept this. Would you like to prepare a patch?

comment:2 Changed 3 years ago by Adam Johnson

Has patch: set

comment:3 Changed 3 years ago by Adam Johnson

Resolution: needsinfo
Status: closed → new

comment:4 Changed 3 years ago by Mariusz Felisiak

Owner: changed from nobody to Adam Johnson
Status: new → assigned
Triage Stage: Unreviewed → Accepted

comment:5 Changed 3 years ago by Mariusz Felisiak

Patch needs improvement: set

comment:6 Changed 2 years ago by Adam Johnson

Patch needs improvement: unset

comment:7 Changed 2 years ago by Mariusz Felisiak

Patch needs improvement: set

comment:8 Changed 2 years ago by Adam Johnson

Patch needs improvement: unset

comment:9 Changed 2 years ago by Mariusz Felisiak

Triage Stage: Accepted → Ready for checkin

comment:10 Changed 2 years ago by Mariusz Felisiak <felisiak.mariusz@…>

In 92975bcd:

Refs #31370 -- Added test for pickling RemoteTestResult.

comment:11 Changed 2 years ago by Mariusz Felisiak <felisiak.mariusz@…>

In e3bca22e:

Refs #31370 -- Made RemoteTestResult subclass unittest.TestResult.

comment:12 Changed 2 years ago by Mariusz Felisiak <felisiak.mariusz@…>

Resolution: → fixed
Status: assigned → closed

In f6713cda:

Fixed #31370 -- Added support for parallel tests with --buffer.

Note: See TracTickets for help on using tickets.
Back to Top