Opened 17 years ago
Closed 17 years ago
#3132 closed enhancement (fixed)
[patch] prefix support for newforms
| Reported by: | jkocherhans | Owned by: | Adrian Holovaty |
|---|---|---|---|
| Component: | Forms | Version: | |
| Severity: | normal | Keywords: | |
| Cc: | jkocherhans@… | Triage Stage: | Unreviewed |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Attachments (1)
Change History (8)
comment:1 by , 17 years ago
| Summary: | prefix support for newforms → [patch] prefix support for newforms |
|---|
comment:2 by , 17 years ago
| Cc: | added |
|---|
by , 17 years ago
| Attachment: | newforms-prefix.diff added |
|---|
comment:3 by , 17 years ago
Kudos to you for using the correct musical taste in the unit tests (Jim Morrison and John Lennon).
:)
comment:4 by , 17 years ago
I see that the patch adds a period between the prefix and the field name. Are periods allowed in HTML id attributes? I think I'll change it to a hyphen...
comment:5 by , 17 years ago
Looks like periods are indeed allowed in HTML id attributes, but they might mess up CSS targeting...
comment:6 by , 17 years ago
You're right about css now that I think about it. It's probably better to use a hyphen in the id. I like the period better in the name, but don't feel strongly either way. Hypens all around would be simpler if they are in the id tho.
comment:7 by , 17 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
Initial support and minimal tests. Needs more work, but feel free to nitpick.