Code

Opened 7 years ago

Closed 7 years ago

#3132 closed enhancement (fixed)

[patch] prefix support for newforms

Reported by: jkocherhans Owned by: adrian
Component: Forms Version:
Severity: normal Keywords:
Cc: jkocherhans@… Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description


Attachments (1)

newforms-prefix.diff (5.4 KB) - added by jkocherhans 7 years ago.
Initial support and minimal tests. Needs more work, but feel free to nitpick.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 7 years ago by jkocherhans

  • Summary changed from prefix support for newforms to [patch] prefix support for newforms

comment:2 Changed 7 years ago by jkocherhans

  • Cc jkocherhans@… added

Changed 7 years ago by jkocherhans

Initial support and minimal tests. Needs more work, but feel free to nitpick.

comment:3 Changed 7 years ago by adrian

Kudos to you for using the correct musical taste in the unit tests (Jim Morrison and John Lennon).

:)

comment:4 Changed 7 years ago by adrian

I see that the patch adds a period between the prefix and the field name. Are periods allowed in HTML id attributes? I think I'll change it to a hyphen...

comment:5 Changed 7 years ago by adrian

Looks like periods are indeed allowed in HTML id attributes, but they might mess up CSS targeting...

comment:6 Changed 7 years ago by jkocherhans

You're right about css now that I think about it. It's probably better to use a hyphen in the id. I like the period better in the name, but don't feel strongly either way. Hypens all around would be simpler if they are in the id tho.

comment:7 Changed 7 years ago by adrian

  • Resolution set to fixed
  • Status changed from new to closed

(In [4194]) Fixed #3132 -- Added prefix support for newforms. Thanks, jkocherhans

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.