Opened 5 months ago

Closed 5 months ago

#31267 closed Cleanup/optimization (fixed)

Missing tests cases for credential validation in URLs.

Reported by: Dennis Schwertel Owned by: Dennis Schwertel
Component: Core (Other) Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description (last modified by Dennis Schwertel)

Hi,
I had an issue with a behavior change introduced with commit cdcf4164bec9dc09465424d7042c3f9d4f0f1fdc. The commit changed the validation of credentials in URLs. This change was not fully covered by test cases and my existing objects now failed to validate. Before the change, credentials in the form of http://:password@host.com where valid.

This is not a big issue as the change fixed an incorrect behavior. I would like to add test cases to cover the current new behavior so changes to the validation are known and intentional.

Change History (5)

comment:1 Changed 5 months ago by Dennis Schwertel

Pull request can be found here. https://github.com/django/django/pull/12448

comment:2 Changed 5 months ago by Dennis Schwertel

CLA signed and send over.

Looking forward to any feedback!

comment:3 Changed 5 months ago by Dennis Schwertel

Description: modified (diff)

comment:4 Changed 5 months ago by felixxm

Component: Core (URLs)Core (Other)
Owner: changed from nobody to Dennis Schwertel
Status: newassigned
Summary: Missing tests cases for credential validation in URLsMissing tests cases for credential validation in URLs.
Triage Stage: UnreviewedAccepted
Version: 2.0master

comment:5 Changed 5 months ago by Mariusz Felisiak <felisiak.mariusz@…>

Resolution: fixed
Status: assignedclosed

In 4070d6ce:

Fixed #31267 -- Added tests cases with empty username or password for URLValidator.

Follow up to cdcf4164bec9dc09465424d7042c3f9d4f0f1fdc.

Note: See TracTickets for help on using tickets.
Back to Top