Opened 5 years ago
Closed 5 years ago
#31267 closed Cleanup/optimization (fixed)
Missing tests cases for credential validation in URLs.
Reported by: | Dennis Schwertel | Owned by: | Dennis Schwertel |
---|---|---|---|
Component: | Core (Other) | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | yes | UI/UX: | no |
Description (last modified by )
Hi,
I had an issue with a behavior change introduced with commit cdcf4164bec9dc09465424d7042c3f9d4f0f1fdc. The commit changed the validation of credentials in URLs. This change was not fully covered by test cases and my existing objects now failed to validate. Before the change, credentials in the form of http://:password@host.com
where valid.
This is not a big issue as the change fixed an incorrect behavior. I would like to add test cases to cover the current new behavior so changes to the validation are known and intentional.
Change History (5)
comment:1 by , 5 years ago
comment:3 by , 5 years ago
Description: | modified (diff) |
---|
comment:4 by , 5 years ago
Component: | Core (URLs) → Core (Other) |
---|---|
Owner: | changed from | to
Status: | new → assigned |
Summary: | Missing tests cases for credential validation in URLs → Missing tests cases for credential validation in URLs. |
Triage Stage: | Unreviewed → Accepted |
Version: | 2.0 → master |
Pull request can be found here. https://github.com/django/django/pull/12448