Opened 5 years ago

Closed 5 years ago

#31183 closed Cleanup/optimization (fixed)

Add a feature flag for "PostgreSQL only supports UNBOUNDED together with PRECEDING and FOLLOWING"

Reported by: Tim Graham Owned by: nobody
Component: Database layer (models, ORM) Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The Django tests for the "PostgreSQL only supports UNBOUNDED together with PRECEDING and FOLLOWING." error are PostgreSQL specific, however, this restriction also applies to CockroachDB. Therefore, it would be nice to have a feature flag to control whether or not those tests are run (rather than a connection.vendor check) as well as not to hardcode "PostgreSQL" in the error message. The ​CockroachDB backend subclasses the PostgreSQL backend.

Change History (3)

comment:1 by Tim Graham, 5 years ago

Has patch: set

​PR

comment:2 by Simon Charette, 5 years ago

Triage Stage: Unreviewed → Accepted

comment:3 by Mariusz Felisiak <felisiak.mariusz@…>, 5 years ago

Resolution: → fixed
Status: new → closed

In 227d0c73:

Fixed #31183 -- Added a feature flag for "<db> only supports UNBOUNDED together with PRECEDING and FOLLOWING".

Note: See TracTickets for help on using tickets.
Back to Top