#3118 closed defect (fixed)
[patch] errata in UPDATE/INSERT section in DB-API document
| Reported by: | Owned by: | Jacob | |
|---|---|---|---|
| Component: | Documentation | Version: | dev |
| Severity: | normal | Keywords: | |
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Isn't this opposite?
django/doc/db-api.txt
line 145
- If the object's primary key attribute is set to a value that evaluates to
False(such asNoneor the empty string), Django executes aSELECTquery to determine whether a record with the given primary key already exists.
Attachments (2)
Change History (8)
comment:1 by , 17 years ago
by , 17 years ago
| Attachment: | fixing_dbapi_doc_erratta.txt added |
|---|
Fixing errata on db-api.txt documentation.
comment:2 by , 17 years ago
| Summary: | DB-API document has description bug. → [patch] DB-API document has description bug. |
|---|
comment:3 by , 17 years ago
| Summary: | [patch] DB-API document has description bug. → [patch] errata in UPDATE/INSERT section in DB-API document |
|---|
by , 17 years ago
| Attachment: | fixing_dbapi_doc_erratta.diff added |
|---|
Fixing errata on db-api.txt documentation (file extension was corrected to .diff sorry for noise).
comment:4 by , 17 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:5 by , 17 years ago
comment:6 by , 17 years ago
That should be Yasushi Masuda. Apologies for getting your name wrong in the commit message.
Note:
See TracTickets
for help on using tickets.
According to a codepath and comment on http://code.djangoproject.com/browser/django/trunk/django/db/models/base.py, lines 172-212,
This should be corrected such as "If the object's primary key attribute is set to a value that evaluates to True (whatever excluding None or empty string), Django executes a ...".
I'll post a patch soon.