Opened 5 years ago
Closed 5 years ago
#31177 closed Cleanup/optimization (wontfix)
Use "raise from" where appropriate
| Reported by: | Ram Rachum | Owned by: | nobody |
|---|---|---|---|
| Component: | Core (Other) | Version: | 3.0 |
| Severity: | Normal | Keywords: | |
| Cc: | Shai Berger | Triage Stage: | Accepted |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description (last modified by )
Following #31166 , I made a regex search to find 90% of places where we use "raise" and should use "raise from".
PR: https://github.com/django/django/pull/12339
If this is too big for one PR, I could split it to smaller chunks.
Change History (7)
comment:1 by , 5 years ago
| Description: | modified (diff) |
|---|
comment:2 by , 5 years ago
| Cc: | added |
|---|---|
| Resolution: | → wontfix |
| Status: | new → closed |
comment:3 by , 5 years ago
Makes sense to me. Started a discussion here: https://groups.google.com/forum/#!topic/django-developers/ibEOt3A9c2M
comment:5 by , 5 years ago
| Resolution: | wontfix |
|---|---|
| Status: | closed → new |
| Triage Stage: | Unreviewed → Accepted |
I think so.
comment:6 by , 5 years ago
PR for adding a section to the style guide: https://github.com/django/django/pull/12350
comment:7 by , 5 years ago
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
Closing as per mailing list discussion.
Note:
See TracTickets
for help on using tickets.
Hi Ram,
I appreciate the good intentions here. However, unlike #31166 which was a local modification, what you're suggesting here is basically a code-style policy change. It is inappropriate to do something like that without a discussion on the DevelopersMailingList, so I am closing this with wontfix -- which essentially just means "you need to convince people about this, and it should not progress until you do".