Opened 9 months ago

Closed 6 months ago

#31123 closed New feature (fixed)

Add option to remove_stale_contenttypes to remove entries for nonexistent apps.

Reported by: Gowtham Kommineni Owned by: Gowtham Kommineni
Component: contrib.contenttypes Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Javier Buzzi)

Add an option (disabled by default) to remove_stale_contenttypes command to remove entries also for nonexistent apps.

Based on discussion.

PR

Change History (6)

comment:1 Changed 9 months ago by felixxm

Resolution: wontfix
Status: newclosed
Summary: remove_stale_contenttypes doesn't remove entries for stale appsremove_stale_contenttypes doesn't remove entries for nonexistent apps.

I don't think that remove_stale_contenttypes should remove content types for nonexistent apps. We don't automatically remove models for nonexistent apps and I don't think we should do this with content types. This can also cause a data loss for a custom content types (not related to real apps). You can start a discussion on DevelopersMailingList if you don't agree.

comment:2 Changed 8 months ago by felixxm

Description: modified (diff)
Has patch: unset
Resolution: wontfix
Status: closednew
Summary: remove_stale_contenttypes doesn't remove entries for nonexistent apps.Add option to remove_stale_contenttypes to remove entries for nonexistent apps.
Triage Stage: UnreviewedAccepted
Type: BugNew feature
Version: 3.0master

Accepted based on discussion .

comment:3 Changed 6 months ago by Javier Buzzi

Description: modified (diff)
Has patch: set
Last edited 6 months ago by felixxm (previous) (diff)

comment:4 Changed 6 months ago by felixxm

Needs documentation: set
Owner: changed from nobody to Gowtham Kommineni
Patch needs improvement: set
Status: newassigned

comment:5 Changed 6 months ago by felixxm

Needs documentation: unset
Patch needs improvement: unset
Triage Stage: AcceptedReady for checkin

comment:6 Changed 6 months ago by Mariusz Felisiak <felisiak.mariusz@…>

Resolution: fixed
Status: assignedclosed

In 142ab684:

Fixed #31123 -- Added --include-stale-apps option to the remove_stale_contenttypes management command.

Co-Authored-By: Javier Buzzi <buzzi.javier@…>

Note: See TracTickets for help on using tickets.
Back to Top