Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#31103 closed Cleanup/optimization (fixed)

Pagination documentation is missing some important detail

Reported by: Mark Bailey Owned by: Mark Bailey
Component: Documentation Version: dev
Severity: Normal Keywords: pagination
Cc: msb@…, Mark Bailey Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

​https://docs.djangoproject.com/en/dev/topics/pagination/ doesn't explicitly describe the Page object. It describes the use of pagination in a ListView, but doesn't cover how the context is affected. The template it suggests wouldn't work for the ListView, and some variable names are potentially confusing.

I have a pull request ready to go, and just saw that I need to open a ticket first.

Change History (5)

comment:1 by Mark Bailey, 4 years ago

Owner: changed from nobody to Mark Bailey
Status: new → assigned

comment:2 by Mark Bailey, 4 years ago

Cc: Mark Bailey added
Has patch: set

Pull request submitted.

comment:3 by Carlton Gibson, 4 years ago

Triage Stage: Unreviewed → Accepted

Hi Mark, I briefly saw the PR come in here, and seems sensible on first look, so let's have this for review. Thank you!

​PR

Last edited 4 years ago by Carlton Gibson (previous) (diff)

comment:4 by Mariusz Felisiak <felisiak.mariusz@…>, 4 years ago

Resolution: → fixed
Status: assigned → closed

In 0f0abc20:

Fixed #31103 -- Improved pagination topic documentation.

comment:5 by Mariusz Felisiak <felisiak.mariusz@…>, 4 years ago

In e7d7e04d:

[3.0.x] Fixed #31103 -- Improved pagination topic documentation.

Backport of 0f0abc20be55d796ecfc3e7698e7ecfd9e9cdf88 from master

Note: See TracTickets for help on using tickets.
Back to Top