Opened 10 years ago

Closed 9 years ago

Last modified 3 years ago

#3108 closed enhancement (wontfix)

Add Form.as_dl() to newforms

Reported by: adrian Owned by: adrian
Component: Forms Version: master
Severity: normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Attachments (1)

as_dl.patch (769 bytes) - added by webograph <webograph@…> 9 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 10 years ago by adrian

  • Resolution set to wontfix
  • Status changed from new to closed

Wontfix -- let's cap the default form output to the three choices we already have.

comment:2 Changed 9 years ago by webograph <webograph@…>

  • Has patch set

is there some particular point in this being closed again? using dl in for list is becoming common practice and gives great possibilities for quickly styling forms in a clean way without having to write html code (plus it looks good from the beginning).

it has been mentioned that the as_ functions are heavily used as shortcuts and that django should handle common cases; i guess this is one!

as of how to handle the error_row, i suggest using u'<dd>%s</dd>') -- it's not perfectly clean from a semantic point of view, but the best we can get in current (x)html.

Changed 9 years ago by webograph <webograph@…>

comment:3 Changed 9 years ago by anonymous

  • Resolution wontfix deleted
  • Status changed from closed to reopened
  • Version set to SVN

please? this is much more usefull than as_p or as_ul

comment:4 Changed 9 years ago by mtredinnick

  • Resolution set to wontfix
  • Status changed from reopened to closed

Please don't reopen tickets that have been wontfixed by a core maintainer. Read the contributing doc for how to take this further. However, since you can easily write your own method, this is really a non-issue, so don't expect too much action.

comment:5 Changed 5 years ago by anonymous

  • Easy pickings unset
  • UI/UX unset

I don't understand how anyone can think form.as_p() or form.as_ul() is in any way a better use case than form.as_dl(). The patch is right there, ready to be reviewed.

comment:6 Changed 3 years ago by anonymous

I'm new to Django, this is one of the things I want to do. Formatting a form using dl is the way to go. See the Twitter Bootstrap for example.

Note: See TracTickets for help on using tickets.
Back to Top