Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#31034 closed New feature (fixed)

Add a navigation sidebar to the admin

Reported by: Tom Carrick Owned by: Tom Carrick
Component: contrib.admin Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: yes

Description

Title says it all, really. The idea is to add an optional (probably enabled by default?) sidebar for navigation, doing roughly what the current homepage does. For now, it'll be a simple implementation only for large screens, and hopefully it can be iterated on in the future.

I opened a discussion here, only got one response but it was positive and I think it's not too controversial if it's behind a flag: ​https://groups.google.com/forum/#!topic/django-developers/PAZw8chsp2g

Change History (20)

comment:1 by Tom Carrick, 5 years ago

Owner: changed from nobody to Tom Carrick
Status: new → assigned

comment:2 by Carlton Gibson, 5 years ago

Triage Stage: Unreviewed → Accepted

OK, thanks. Accepting on the basis of the discussion. 👍

comment:3 by Tom Carrick, 5 years ago

Has patch: set
Needs documentation: set
Needs tests: set
UI/UX: set

​PR

Needs tests and docs but wanted to get some feedback first.

Last edited 5 years ago by Mariusz Felisiak (previous) (diff)

comment:4 by Tom Carrick, 5 years ago

Needs tests: unset

comment:5 by Tom Carrick, 5 years ago

Needs documentation: unset

comment:6 by Tim Graham, 5 years ago

To control its display, I'd think an admin site attribute would be preferred to a setting. Generally, settings are only added as a last resort.

comment:7 by Mariusz Felisiak, 5 years ago

Patch needs improvement: set

comment:8 by Tom Carrick, 5 years ago

Patch needs improvement: unset

Thanks. I've fixed that, now I'm just having a problem figuring out the test failure.

comment:9 by Carlton Gibson, 5 years ago

Patch needs improvement: set

I posted to the mailing list thread to see if we can find a Design/UX/CSS expert to input on the PR.

If not, I think we should proceed. It's a improvement, and we can iterate on it over time.

There's one CSS issue that we should resolve (at least) commented on the PR.

comment:10 by Tom Carrick, 5 years ago

Patch needs improvement: unset

comment:11 by Tom Carrick, 5 years ago

Patch needs improvement: set

comment:12 by Tom Carrick, 5 years ago

Patch needs improvement: unset

comment:13 by Carlton Gibson, 5 years ago

Triage Stage: Accepted → Ready for checkin

comment:14 by Mariusz Felisiak <felisiak.mariusz@…>, 5 years ago

Resolution: → fixed
Status: assigned → closed

In d24ba1be:

Fixed #31034 -- Added a navigation sidebar to the admin.

Co-authored-by: elky <elky@…>
Co-authored-by: Goetz <goetz.buerkle@…>

comment:15 by Mariusz Felisiak <felisiak.mariusz@…>, 5 years ago

In e341bed6:

Refs #31034 -- Documented admin requires django.template.context_processors.request.

Required since d24ba1be7a53a113d19e2860c03aff9922efec24.

Co-authored-by: Carlton Gibson <carlton.gibson@…>

comment:16 by Mariusz Felisiak <felisiak.mariusz@…>, 5 years ago

In c9a9d042:

[3.1.x] Refs #31034 -- Documented admin requires django.template.context_processors.request.

Required since d24ba1be7a53a113d19e2860c03aff9922efec24.

Co-authored-by: Carlton Gibson <carlton.gibson@…>

Backport of e341bed606d8ab2864838795276692cf86b08687 from master

comment:17 by Mariusz Felisiak <felisiak.mariusz@…>, 5 years ago

In e46f700:

Refs #31034 -- Used === in nav_sidebar.js admin JS to avoid possible coercion issues.

comment:18 by Mariusz Felisiak <felisiak.mariusz@…>, 5 years ago

In 16716551:

[3.1.x] Refs #31034 -- Used === in nav_sidebar.js admin JS to avoid possible coercion issues.

Backport of e46f700e39cef3856f34b56dc5d563d3e27648ac from master

comment:19 by Mariusz Felisiak <felisiak.mariusz@…>, 5 years ago

In 780473d:

Refs #31034 -- Improved accessibility of admin navigation sidebar.

comment:20 by Mariusz Felisiak <felisiak.mariusz@…>, 5 years ago

In dc3234be:

[3.1.x] Refs #31034 -- Improved accessibility of admin navigation sidebar.

Backport of 780473d75625d014cbe9b0acdea40b7a5970d5d8 from master

Note: See TracTickets for help on using tickets.
Back to Top