Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#30948 closed Cleanup/optimization (fixed)

Change packaging to use setup.cfg declarative syntax

Reported by: Jon Dufresne Owned by: nobody
Component: Packaging Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

setuptools feature: https://setuptools.readthedocs.io/en/latest/setuptools.html#configuring-setup-using-setup-cfg-files

Available since setuptools 30.3.0 (8 Dec 2016).

Using setup.cfg reduces boilerplate and logic in setup.py. As setup.cfg is a simple data format, it could allow for automation with external tools in the future.

Change History (9)

comment:2 by Nick Pope, 4 years ago

Triage Stage: UnreviewedAccepted

I think this will make things much easier. Even setuptools itself does this now.

By the time Django 3.1 is released, this will have been supported for nearly 4 years.

comment:3 by Carlton Gibson, 4 years ago

Patch needs improvement: set

PR has grown in scope to incorporate a few things. (License change, other clean ups, ...) If we can pull that out separately, we can assess this change on it's own. (Thanks for the effort — looks good.)

comment:4 by Jon Dufresne, 4 years ago

Patch needs improvement: unset

Feedback addressed and reduced PR in scope.

comment:5 by Carlton Gibson, 4 years ago

Triage Stage: AcceptedReady for checkin

comment:6 by Mariusz Felisiak <felisiak.mariusz@…>, 4 years ago

In bca2ffd:

[3.0.x] Refs #30948 -- Updated install instructions to use pip instead of setup.py.

Co-authored-by: Nick Pope <nick.pope@…>

Backport of eee4da3b5748370a5c562bc63d2cae61ea85b16c from master

comment:7 by Mariusz Felisiak <felisiak.mariusz@…>, 4 years ago

In eee4da3b:

Refs #30948 -- Updated install instructions to use pip instead of setup.py.

Co-authored-by: Nick Pope <nick.pope@…>

comment:8 by Mariusz Felisiak <felisiak.mariusz@…>, 4 years ago

Resolution: fixed
Status: newclosed

In 85efc14a:

Fixed #30948 -- Changed packaging to use declarative config in setup.cfg.

Co-authored-by: Nick Pope <nick.pope@…>

comment:9 by Mariusz Felisiak <felisiak.mariusz@…>, 4 years ago

In 3627fc5e:

[2.2.x] Refs #30948 -- Updated install instructions to use pip instead of setup.py.

Co-authored-by: Nick Pope <nick.pope@…>

Backport of eee4da3b5748370a5c562bc63d2cae61ea85b16c from master

Note: See TracTickets for help on using tickets.
Back to Top