FilePathField raises FileNotFoundError for nonexistent path.

[Jason Held]

The docs around the model of FilePathField show the path as being default None, while the code is empty string.

Also, due to a change in 2.2 around using scandir on the form field for FilePathField, if the path doesn't exist, a FileNotFoundError is issued (same would have happened before the scandir change), but now the try/except logic on OSError (super class) has been removed, in the PR that changed to scandir.

So, the docs are out of date (regardless of whichever value is more sane as a default), and the change on scandir also removed the try/except.

Previously it was not an issue because there was a try/except, so we were caught off guard.

[Mariusz Felisiak]

Thanks for this report, I agree that it's a regression in a0ca4b5694f43c63ea13ba6908eff2bd53ee7ebb. We should restore catching OSError. Documentation issue is not a regression so I sent a separate ​PR with fix.

Reproduced at fc2b1cc926e34041953738e58fa6ad3053059b22.

[Mariusz Felisiak]

Regression test.

[GitHub <noreply@…>]

In daa9415f:

Refs #30908 -- Fixed the empty value of forms.FilePathField in docs.

[Mariusz Felisiak <felisiak.mariusz@…>]

In 76964cc:

[3.0.x] Refs #30908 -- Fixed the empty value of forms.FilePathField in docs.

Backport of daa9415f78279855808134e1f40766f6c5f4bdbc from master

[Mariusz Felisiak <felisiak.mariusz@…>]

In 48df402:

[2.2.x] Refs #30908 -- Fixed the empty value of forms.FilePathField in docs.

Backport of daa9415f78279855808134e1f40766f6c5f4bdbc from master

[Mariusz Felisiak]

Sorry for the previous acceptance, but it is ​documented from the very beginning that "This directory must exist" (see 4457ba002d64d4a991b0561c5be69a8c61b2b828). We removed catching OSError in Django 2.2, but it was untested and undocumented behavior.

[Hasan Ramezani]

Would it be good to add a test case for OSError?

[Mariusz Felisiak <felisiak.mariusz@…>]

In 6c6d24a4:

Refs #30908 -- Added test for nonexistent path in forms.FilePathField.