Code

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#3080 closed defect (fixed)

[bug] delete_cookie method imporoperly sets the domain parameter in django/http/!__init!__.py

Reported by: nowell strite Owned by: adrian
Component: Core (Other) Version: master
Severity: normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

In django/http/__init__.py the delete_cookie method improperly sets the domain parameter to the path parameter. Below is a patch that corrects the oversight.

Index: django/http/__init__.py
===================================================================
--- django/http/__init__.py	(revision 4126)
+++ django/http/__init__.py	(working copy)
@@ -208,7 +208,7 @@
         if path is not None:
             self.cookies[key]['path'] = path
         if domain is not None:
-            self.cookies[key]['domain'] = path
+            self.cookies[key]['domain'] = domain
         self.cookies[key]['expires'] = 0
         self.cookies[key]['max-age'] = 0

Attachments (0)

Change History (2)

comment:1 Changed 7 years ago by adrian

  • Resolution set to fixed
  • Status changed from new to closed

(In [4135]) Fixed #3080 -- Fixed bug in delete_cookie() method. Thanks, nowell strite

comment:2 Changed 7 years ago by anonymous

  • milestone Version 1.0 deleted

Milestone Version 1.0 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.