Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#3080 closed defect (fixed)

[bug] delete_cookie method imporoperly sets the domain parameter in django/http/!__init!

Reported by: nowell strite Owned by: Adrian Holovaty
Component: Core (Other) Version: master
Severity: normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


In django/http/ the delete_cookie method improperly sets the domain parameter to the path parameter. Below is a patch that corrects the oversight.

Index: django/http/
--- django/http/	(revision 4126)
+++ django/http/	(working copy)
@@ -208,7 +208,7 @@
         if path is not None:
             self.cookies[key]['path'] = path
         if domain is not None:
-            self.cookies[key]['domain'] = path
+            self.cookies[key]['domain'] = domain
         self.cookies[key]['expires'] = 0
         self.cookies[key]['max-age'] = 0

Change History (2)

comment:1 Changed 10 years ago by Adrian Holovaty

Resolution: fixed
Status: newclosed

(In [4135]) Fixed #3080 -- Fixed bug in delete_cookie() method. Thanks, nowell strite

comment:2 Changed 10 years ago by (none)

milestone: Version 1.0

Milestone Version 1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top