Opened 8 years ago

Closed 8 years ago

#3073 closed defect (invalid)

[patch] Fix invalid 'action' on form in add_user.html

Reported by: Collin Grady <cgrady@…> Owned by: nobody
Component: contrib.admin Version:
Severity: normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Current view doesn't seem to be sending in a form_url value to the context for add_form.html, which extends change_user.html

This is causing the action to show up as [TEMPLATE_ERROR] - this patch merely adds a line setting 'form_url' to '.' which appears to solve the issue.

Attachments (1)

auth-add-user-action.patch (489 bytes) - added by Collin 8 years ago.

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by Collin

comment:1 follow-up: Changed 8 years ago by Collin

A valid point was just made in IRC - this only presents itself if you're using TEMPLATE_STRING_IF_INVALID

comment:2 Changed 8 years ago by Simon G. <dev@…>

  • Triage Stage changed from Unreviewed to Accepted

comment:3 in reply to: ↑ 1 Changed 8 years ago by ubernostrum

  • Resolution set to invalid
  • Status changed from new to closed

Replying to Collin:

A valid point was just made in IRC - this only presents itself if you're using TEMPLATE_STRING_IF_INVALID

Since use of TEMPLATE_STRING_IF_INVALID is highly discouraged and that setting is known to break bits of the admin unless you only use it for isolated debugging, and since the admin is being rewritten anyway, I'm inclined to mark this invalid.

Note: See TracTickets for help on using tickets.
Back to Top