Opened 5 years ago
Closed 5 years ago
#30693 closed Cleanup/optimization (fixed)
Refatoring django.core.management.templates
| Reported by: | Maaz Bin Tahir Saeed | Owned by: | Maaz Bin Tahir Saeed |
|---|---|---|---|
| Component: | Core (Management commands) | Version: | dev |
| Severity: | Normal | Keywords: | core management templates |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | yes | UI/UX: | no |
Description (last modified by )
'path' module is being used as an absolute import as well as relative import.
Proposing to remove the relative import and refactor all relative imports to absolute imports.
e.g from 'path.join(some_path)' to 'os.path.join(some_path)'
Proposed changes: https://github.com/Diaga/django/tree/ticket_30693
Change History (4)
comment:1 by , 5 years ago
| Description: | modified (diff) |
|---|
comment:2 by , 5 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|---|
| Version: | 2.2 → master |
comment:3 by , 5 years ago
| Triage Stage: | Accepted → Ready for checkin |
|---|
Looks good. Just needs a squash and a final look before merging.
Note:
See TracTickets
for help on using tickets.
Hiya, yes this seems reasonable enough to me. Thanks.