Opened 6 years ago

Closed 6 years ago

#30693 closed Cleanup/optimization (fixed)

Refatoring django.core.management.templates

Reported by: Maaz Bin Tahir Saeed Owned by: Maaz Bin Tahir Saeed
Component: Core (Management commands) Version: dev
Severity: Normal Keywords: core management templates
Cc: Triage Stage: Ready for checkin
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description (last modified by Maaz Bin Tahir Saeed)

'path' module is being used as an absolute import as well as relative import.
Proposing to remove the relative import and refactor all relative imports to absolute imports.
e.g from 'path.join(some_path)' to 'os.path.join(some_path)'

Proposed changes: ​https://github.com/Diaga/django/tree/ticket_30693

Change History (4)

comment:1 by Maaz Bin Tahir Saeed, 6 years ago

Description: modified (diff)

comment:2 by Carlton Gibson, 6 years ago

Triage Stage: Unreviewed → Accepted
Version: 2.2 → master

Hiya, yes this seems reasonable enough to me. Thanks.

comment:3 by Carlton Gibson, 6 years ago

Triage Stage: Accepted → Ready for checkin

Looks good. Just needs a squash and a final look before merging.

comment:4 by Carlton Gibson <carlton.gibson@…>, 6 years ago

Resolution: → fixed
Status: assigned → closed

In e9f74f5:

Fixed #30693 -- Removed separate import of os.path in django.core.management.templates.

Note: See TracTickets for help on using tickets.
Back to Top