Opened 6 years ago

Closed 6 years ago

Last modified 7 months ago

#30613 closed Cleanup/optimization (fixed)

Move index name checks from Index.__init__ into system checks.

Reported by: Can Sarıgöl Owned by: Can Sarıgöl
Component: Database layer (models, ORM) Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Mariusz Felisiak)

Index names assertions should be moved to system checks to keep code cleaner and more consistent.

Change History (4)

comment:1 by Can Sarıgöl, 6 years ago

Has patch: set
Owner: changed from nobody to Can Sarıgöl
Status: new → assigned

​PR

comment:2 by Mariusz Felisiak, 6 years ago

Description: modified (diff)
Summary: Move index name check from Index.__init__ into system checks. → Move index name checks from Index.__init__ into system checks.
Triage Stage: Unreviewed → Accepted

comment:3 by Mariusz Felisiak <felisiak.mariusz@…>, 6 years ago

Resolution: → fixed
Status: assigned → closed

In 53209f78:

Fixed #30613 -- Moved index name validation to system checks.

comment:4 by Tim Graham, 7 months ago

I'm not sure that moving this validation was appropriate. Index.__init__() does ​a lot argument validation and I don't see a reason why the validation of name should be treated differently. See ticket:36273#comment:7.

Note: See TracTickets for help on using tickets.
Back to Top