[patch] WSGI handler expects CONTENT_LENGTH to be always present

[Ivan Sagalaev <Maniac@…>]

CONTENT_LENGTH may be absent if a POST request doesn't have a content at all (at least with lighttpd). This is BTW not so rare thing especially in ajax stuff: when calling XmlHttpRequest.send() without data for POST requests Firefox doesn't include nor data, neither Content-Length. May be others too.

Fix is trivial, patch follows.

[Ivan Sagalaev <Maniac@…>]

Fix

[Adrian Holovaty]

(In [4091]) Fixed #3057 -- Changed WSGI handler not to expect CONTENT_LENGTH. Thanks for the patch, Ivan Sagalaev

[Barry Pederson <bp@…>]

It looks like that patch didn't go in correctly, it shows

content_length = int(self.environ.get('CONTENT_LENGTH', ))

missing the zero as the second parameter to the get() call.

[Adrian Holovaty]

(In [4094]) Fixed #3057 -- Fixed typo in [4091]. Thanks for the heads-up, Barry Pederson

[Ivan Sagalaev <Maniac@…>]

Greg Chapman in django-developers points out that CONTENT_LENGTH may be present but contain an empty string which than fails with ValueError.

[Ivan Sagalaev <Maniac@…>]

Fixing empty string in Content-Length

[glchapman42@…]

Sorry to comment on a closed report, but I've I've been getting an apparent blocked socket during the call to safe_copyfileobj when content_length == 0 (that is, the browser never receives a response from Django). (By the way, I'm using Python 2.5, so I downloaded the development version. Also, operating system is Windows XP and I'm just using the built-in HTTP server to work through the Tutorial). FWIW, extending the _get_raw_post_data patch to have the following has removed the block:

            try:
                # CONTENT_LENGTH might be absent if POST doesn't have content at all (lighttpd)
                content_length = int(self.environ.get('CONTENT_LENGTH', 0))
            except ValueError:
                content_length = 0
            if content_length:
                safe_copyfileobj(self.environ['wsgi.input'], buf, size=content_length)
                self._raw_post_data = buf.getvalue()
            else:
                self._raw_post_data = ''

[Adrian Holovaty]

Fixed in [4107].