#30555 closed Bug (wontfix)
Migration files generated do not follow PEP8 E501 rule
| Reported by: | Aman Sharma | Owned by: | nobody |
|---|---|---|---|
| Component: | Migrations | Version: | 2.2 |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Migration files, which are automatically created by Django on running python manage.py makemigrations, do not seem to follow PEP8 guidelines completely. The rule E501 line too long is not respected in the file. I have attached a file to support my arguments.
Attachments (1)
Change History (5)
by , 6 years ago
| Attachment: | Screenshot from 2019-06-08 11-40-35.png added |
|---|
comment:1 by , 6 years ago
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
This isn’t something worth addressing. I suggest you add migrations folders to the flake8 exclude list.
comment:3 by , 6 years ago
Ooh really?
It's a little inconsistent currently, with how the dependencies list (from makemigrations) gets nicely newlined, whereas the replaces list (from squashmigrations) doesn't.
This has been a little pet peeve of mine for yonks, where replaces lists are difficult to interact with when doing manual migration tinkering, but I never got round to raising a ticket for it..
Despite this being closed as a wontfix, would a PR still be accepted if one were submitted? :D
PEP8 throwing warnings when ran on
migrationsdirectory