Opened 5 years ago

Closed 5 years ago

#30529 closed Bug (invalid)

SQLCompiler.as_sql should return parameters as a list (and not as a tuple)

Reported by: Tobias Krönke Owned by: nobody
Component: Database layer (models, ORM) Version: 2.2
Severity: Normal Keywords:
Cc: me@… Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

As wished by Adam (​https://github.com/adamchainz/django-mysql/issues/50#issuecomment-496665473) I will give it a try and do a PR to turn those tuples into lists. Even the method comments in ​https://github.com/django/django/blob/master/django/db/models/sql/compiler.py all state:

Return the SQL string and list of parameters.

Change History (1)

comment:1 by Tobias Krönke, 5 years ago

Resolution: → invalid
Status: new → closed

Tuples, it is. ​https://github.com/django/django/pull/11430

Note: See TracTickets for help on using tickets.
Back to Top