Opened 6 months ago

Closed 6 months ago

Last modified 6 months ago

#30523 closed Bug (fixed)

StatReloader does not update file times if notify_file_changed() is triggered.

Reported by: Tom Forbes Owned by: Tom Forbes
Component: Utilities Version: 2.2
Severity: Release blocker Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

If notify_file_changed is triggered then the files mtime is not updated. This can cause notify_file_changed() to be triggered many times if a translation is changed.

Change History (5)

comment:1 Changed 6 months ago by Tom Forbes

Component: UncategorizedUtilities
Has patch: set
Owner: changed from nobody to Tom Forbes
Status: newassigned
Triage Stage: UnreviewedAccepted
Type: UncategorizedBug

comment:2 Changed 6 months ago by felixxm

Summary: StatReloader does not update file times if notify_file_changed() is triggeredStatReloader does not update file times if notify_file_changed() is triggered.
Triage Stage: AcceptedUnreviewed

You shouldn't accept you're own tickets ;)

Last edited 6 months ago by felixxm (previous) (diff)

comment:3 Changed 6 months ago by felixxm

Severity: NormalRelease blocker
Triage Stage: UnreviewedAccepted

comment:4 Changed 6 months ago by Mariusz Felisiak <felisiak.mariusz@…>

Resolution: fixed
Status: assignedclosed

In 480492fe:

Fixed #30523 -- Fixed updating file modification times on seen files in auto-reloader when using StatReloader.

Previously we updated the file mtimes if the file has not been seen
before - i.e on the first iteration of the loop.

If the mtime has been changed we triggered the notify_file_changed()
method which in all cases except the translations will result in the
process being terminated. To be strictly correct we need to update the
mtime for either branch of the conditional.

Regression in 6754bffa2b2df15a741008aa611c1bb0e8dff22b.

comment:5 Changed 6 months ago by Mariusz Felisiak <felisiak.mariusz@…>

In 7089502b:

[2.2.x] Fixed #30523 -- Fixed updating file modification times on seen files in auto-reloader when using StatReloader.

Previously we updated the file mtimes if the file has not been seen
before - i.e on the first iteration of the loop.

If the mtime has been changed we triggered the notify_file_changed()
method which in all cases except the translations will result in the
process being terminated. To be strictly correct we need to update the
mtime for either branch of the conditional.

Regression in 6754bffa2b2df15a741008aa611c1bb0e8dff22b.

Backport of 480492fe70b0bb7df61c00854dc8535c9d21ba64 from master

Note: See TracTickets for help on using tickets.
Back to Top