Opened 4 years ago

Closed 4 years ago

#30486 closed Bug (fixed)

Custom aggregate function example needs updating for Django 2.2's `allow_distinct`

Reported by: Carlton Gibson Owned by: Vyacheslav V.V.
Component: Documentation Version: 2.2
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

#28658 added the Aggregate.allow_distinct attribute. The example of the custom Count needs updating to use this.

​PR already begun.

Change History (5)

comment:1 Changed 4 years ago by Carlton Gibson

Patch needs improvement: set

comment:2 Changed 4 years ago by Vyacheslav V.V.

Owner: changed from nobody to Vyacheslav V.V.
Status: new → assigned

comment:3 Changed 4 years ago by Vyacheslav V.V.

I have created ​PR

comment:4 Changed 4 years ago by Vyacheslav V.V.

Patch needs improvement: unset

comment:5 Changed 4 years ago by Mariusz Felisiak <felisiak.mariusz@…>

Resolution: → fixed
Status: assigned → closed

In 76b3fc5c:

Fixed #30486 -- Fixed the default value of Aggregate.distinct and updated example of custom aggregate functions.

Note: See TracTickets for help on using tickets.
Back to Top