Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#30478 closed Uncategorized (wontfix)

Do not require npm installed for JavaScript tests (tox -e javascript)

Reported by: Ivan Kolodyazhny Owned by: Ivan Kolodyazhny
Component: Uncategorized Version: 2.2
Severity: Normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

We can omit Node.JS/npm installation for JavaScript tests by using nodeenv (https://pypi.org/project/nodeenv/)

Change History (2)

comment:1 Changed 2 years ago by Carlton Gibson

Resolution: wontfix
Status: assignedclosed

I'm not initially seeing the benefit here. nodeenv doesn't avoid you needing to install node/npm. It just does controls that process for you, allowing you to install and manage multiple node versions.

The PyPI package is just a wrapper around the main `nodeenv` project right? I can see that someone might want to use this themselves. (I use it in fact.) But I can't see why I'd want to install this in my Python virtualenv: it strikes me as adding a nesting where we don't need one. (I'm sure the Zen of Python says something about that. 🙂)

Installing node is not a big issue IMO.

comment:2 Changed 2 years ago by Ivan Kolodyazhny

You're right, Carlton. I'm just trying to keep my development environment as clean as possible without the installation of some software which is not required to be installed on my laptop or desktop.

Note: See TracTickets for help on using tickets.
Back to Top